From: Jonathan Cameron <jic23@kernel.org>
To: Harinath Nampally <harinath922@gmail.com>, lars@metafoo.de
Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments.
Date: Sun, 14 May 2017 16:26:57 +0100 [thread overview]
Message-ID: <964e06e3-2951-c41c-34e9-aae6c53c040a@kernel.org> (raw)
In-Reply-To: <39df9167707c234aeed4825e5aded97056d565c5.1494370925.git.harinath922@gmail.com>
On 10/05/17 00:41, Harinath Nampally wrote:
> This patch fixes below checkpatch.pl kind of warnings:
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Good patch and well described.
Applied this one (without patch 1) to the togreg branch of
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/
which is initially pushed out as testing for the autobuilders
to see if we've missed anything.
Thanks,
Jonathan
> ---
> Changes in v2:
> - None because only [PATCH v2 1/3] has improvement
>
> drivers/staging/iio/meter/ade7753.c | 55 ++++++++++++++++++-------------------
> 1 file changed, 27 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c
> index cffe6bf..5d45a68 100644
> --- a/drivers/staging/iio/meter/ade7753.c
> +++ b/drivers/staging/iio/meter/ade7753.c
> @@ -108,9 +108,8 @@ static int ade7753_spi_write_reg_8(struct device *dev,
> return ret;
> }
>
> -static int ade7753_spi_write_reg_16(struct device *dev,
> - u8 reg_address,
> - u16 value)
> +static int ade7753_spi_write_reg_16(struct device *dev, u8 reg_address,
> + u16 value)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -127,8 +126,8 @@ static int ade7753_spi_write_reg_16(struct device *dev,
> }
>
> static int ade7753_spi_read_reg_8(struct device *dev,
> - u8 reg_address,
> - u8 *val)
> + u8 reg_address,
> + u8 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7753_state *st = iio_priv(indio_dev);
> @@ -137,7 +136,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
> ret = spi_w8r8(st->us, ADE7753_READ_REG(reg_address));
> if (ret < 0) {
> dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
> - reg_address);
> + reg_address);
> return ret;
> }
> *val = ret;
> @@ -146,8 +145,8 @@ static int ade7753_spi_read_reg_8(struct device *dev,
> }
>
> static int ade7753_spi_read_reg_16(struct device *dev,
> - u8 reg_address,
> - u16 *val)
> + u8 reg_address,
> + u16 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7753_state *st = iio_priv(indio_dev);
> @@ -166,8 +165,8 @@ static int ade7753_spi_read_reg_16(struct device *dev,
> }
>
> static int ade7753_spi_read_reg_24(struct device *dev,
> - u8 reg_address,
> - u32 *val)
> + u8 reg_address,
> + u32 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7753_state *st = iio_priv(indio_dev);
> @@ -190,7 +189,7 @@ static int ade7753_spi_read_reg_24(struct device *dev,
> ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
> if (ret) {
> dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
> - reg_address);
> + reg_address);
> goto error_ret;
> }
> *val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];
> @@ -201,8 +200,8 @@ static int ade7753_spi_read_reg_24(struct device *dev,
> }
>
> static ssize_t ade7753_read_8bit(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> int ret;
> u8 val;
> @@ -216,8 +215,8 @@ static ssize_t ade7753_read_8bit(struct device *dev,
> }
>
> static ssize_t ade7753_read_16bit(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> int ret;
> u16 val;
> @@ -231,8 +230,8 @@ static ssize_t ade7753_read_16bit(struct device *dev,
> }
>
> static ssize_t ade7753_read_24bit(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> int ret;
> u32 val;
> @@ -246,9 +245,9 @@ static ssize_t ade7753_read_24bit(struct device *dev,
> }
>
> static ssize_t ade7753_write_8bit(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + struct device_attribute *attr,
> + const char *buf,
> + size_t len)
> {
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> int ret;
> @@ -264,9 +263,9 @@ static ssize_t ade7753_write_8bit(struct device *dev,
> }
>
> static ssize_t ade7753_write_16bit(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + struct device_attribute *attr,
> + const char *buf,
> + size_t len)
> {
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> int ret;
> @@ -451,8 +450,8 @@ static int ade7753_initial_setup(struct iio_dev *indio_dev)
> }
>
> static ssize_t ade7753_read_frequency(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> int ret;
> u16 t;
> @@ -469,9 +468,9 @@ static ssize_t ade7753_read_frequency(struct device *dev,
> }
>
> static ssize_t ade7753_write_frequency(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + struct device_attribute *attr,
> + const char *buf,
> + size_t len)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7753_state *st = iio_priv(indio_dev);
>
next prev parent reply other threads:[~2017-05-14 15:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1494215850-26005-1-git-send-email-harinath922@gmail.com>
2017-05-09 1:49 ` [PATCH 0/3] coding style warnings fixes Harinath Nampally
2017-05-09 1:49 ` [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition Harinath Nampally
2017-05-09 7:46 ` Dan Carpenter
2017-05-09 23:41 ` [PATCH v2 0/3] coding style warnings fixes Harinath Nampally
2017-05-09 23:41 ` [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition Harinath Nampally
2017-05-14 15:24 ` Jonathan Cameron
2017-05-09 23:41 ` [PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments Harinath Nampally
2017-05-14 15:26 ` Jonathan Cameron [this message]
2017-05-09 23:41 ` [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions Harinath Nampally
2017-05-14 15:29 ` Jonathan Cameron
2017-05-15 3:10 ` harinath Nampally
2017-05-14 15:23 ` [PATCH v2 0/3] coding style warnings fixes Jonathan Cameron
2017-05-09 1:49 ` [PATCH 2/3] staging: iio: meter: Fix the identations for proper alignments Harinath Nampally
2017-05-09 1:49 ` [PATCH 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions Harinath Nampally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964e06e3-2951-c41c-34e9-aae6c53c040a@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harinath922@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).