From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>, Lv Zheng <lv.zheng@intel.com>
Cc: Jiri Eischmann <jeischma@redhat.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] acpi/button: revert v4.10 behavior
Date: Wed, 10 May 2017 18:12:38 +0200 [thread overview]
Message-ID: <20170510161240.13229-1-benjamin.tissoires@redhat.com> (raw)
The new default 'open' behavior for acpi_lid_initialize_state() is just
wrong. It breaks professional laptops with a docking station [1].
Booting the laptop with the LID closed is something common and now there
is no way of knowing the actual state of the LID switch at boot. Please
use a user-space solution as described in 2/2 if you really don't want to
add quirks in the kernel.
Cheers,
Benjamin
[1] https://bugzilla.gnome.org/show_bug.cgi?id=782380
Benjamin Tissoires (2):
Revert "ACPI / button: Remove lid_init_state=method mode"
Revert "ACPI / button: Change default behavior to lid_init_state=open"
Documentation/acpi/acpi-lid.txt | 16 ++++++++++++----
drivers/acpi/button.c | 11 ++++++++++-
2 files changed, 22 insertions(+), 5 deletions(-)
--
2.9.3
next reply other threads:[~2017-05-10 16:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 16:12 Benjamin Tissoires [this message]
2017-05-10 16:12 ` [PATCH 1/2] Revert "ACPI / button: Remove lid_init_state=method mode" Benjamin Tissoires
2017-05-11 0:58 ` Zheng, Lv
2017-05-11 1:19 ` Zheng, Lv
2017-05-11 10:12 ` Benjamin Tissoires
2017-05-12 5:08 ` Zheng, Lv
2017-05-12 9:50 ` Benjamin Tissoires
2017-05-15 4:54 ` Zheng, Lv
2017-05-15 7:42 ` Benjamin Tissoires
2017-05-16 5:05 ` Zheng, Lv
2017-05-10 16:12 ` [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" Benjamin Tissoires
2017-05-11 0:59 ` Zheng, Lv
2017-05-11 9:45 ` Benjamin Tissoires
2017-05-12 2:36 ` Zheng, Lv
2017-05-12 21:50 ` Rafael J. Wysocki
2017-05-15 7:45 ` Benjamin Tissoires
2017-05-15 9:17 ` Rafael J. Wysocki
2017-05-15 9:37 ` Benjamin Tissoires
2017-05-15 11:01 ` Rafael J. Wysocki
2017-05-15 13:05 ` Benjamin Tissoires
2017-05-16 5:33 ` Zheng, Lv
2017-05-16 5:47 ` Zheng, Lv
2017-05-16 7:15 ` Benjamin Tissoires
2017-05-16 8:30 ` Zheng, Lv
2017-05-16 10:10 ` Benjamin Tissoires
2017-05-17 7:32 ` Zheng, Lv
2017-05-17 11:54 ` Peter Hutterer
2017-05-17 14:16 ` Benjamin Tissoires
2017-05-24 8:08 ` Benjamin Tissoires
2017-05-24 23:01 ` Rafael J. Wysocki
2017-05-25 6:17 ` Zheng, Lv
2017-05-26 7:39 ` Peter Hutterer
2017-05-27 19:23 ` Rafael J. Wysocki
2017-05-11 0:09 ` [PATCH 0/2] acpi/button: revert v4.10 behavior Rafael J. Wysocki
2017-05-11 9:33 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510161240.13229-1-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jeischma@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).