* [PATCH] serial: altera_jtaguart: adding iounmap()
@ 2017-05-12 21:36 Alexey Khoroshilov
2017-05-13 11:00 ` Tobias Klauser
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Khoroshilov @ 2017-05-12 21:36 UTC (permalink / raw)
To: Tobias Klauser, Greg Kroah-Hartman
Cc: Alexey Khoroshilov, Jiri Slaby, linux-serial, nios2-dev,
linux-kernel, ldv-project
The driver does ioremap(port->mapbase, ALTERA_JTAGUART_SIZE),
but there is no any iounmap().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/tty/serial/altera_jtaguart.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c
index 18e3f8342b85..0475f5d261ce 100644
--- a/drivers/tty/serial/altera_jtaguart.c
+++ b/drivers/tty/serial/altera_jtaguart.c
@@ -478,6 +478,7 @@ static int altera_jtaguart_remove(struct platform_device *pdev)
port = &altera_jtaguart_ports[i].port;
uart_remove_one_port(&altera_jtaguart_driver, port);
+ iounmap(port->membase);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: altera_jtaguart: adding iounmap()
2017-05-12 21:36 [PATCH] serial: altera_jtaguart: adding iounmap() Alexey Khoroshilov
@ 2017-05-13 11:00 ` Tobias Klauser
0 siblings, 0 replies; 2+ messages in thread
From: Tobias Klauser @ 2017-05-13 11:00 UTC (permalink / raw)
To: Alexey Khoroshilov
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, nios2-dev,
linux-kernel, ldv-project
On 2017-05-12 at 23:36:22 +0200, Alexey Khoroshilov <khoroshilov@ispras.ru> wrote:
> The driver does ioremap(port->mapbase, ALTERA_JTAGUART_SIZE),
> but there is no any iounmap().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Tobias Klauser <tklauser@distanz.ch>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-13 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12 21:36 [PATCH] serial: altera_jtaguart: adding iounmap() Alexey Khoroshilov
2017-05-13 11:00 ` Tobias Klauser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).