From: Mark Brown <broonie@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times
Date: Sun, 14 May 2017 19:16:52 +0900 [thread overview]
Message-ID: <20170514101652.waoc5fhjzpd2emoq@sirena.org.uk> (raw)
In-Reply-To: <20170501183715.35375-2-mka@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
On Mon, May 01, 2017 at 11:37:15AM -0700, Matthias Kaehlcke wrote:
> else if (rdev->constraints->settling_time)
> return rdev->constraints->settling_time;
> + else if (rdev->constraints->settling_time_up &&
> + (new_uV > old_uV))
> + return rdev->constraints->settling_time_up;
> + else if (rdev->constraints->settling_time_down &&
> + (new_uV < old_uV))
> + return rdev->constraints->settling_time_down;
It feels like we should warn if the user mixes specific up/down settling
times with the more general property, can you please send a followup
patch adding a warning for that? It's not exactly obvious what the
precedence is and may do the wrong thing with an older kernel or
non-Linux OS.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-05-15 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 18:37 [PATCH v2 1/2] regulator: DT: Add properties for asymmetric settling times Matthias Kaehlcke
2017-05-01 18:37 ` [PATCH v2 2/2] regulator: Allow " Matthias Kaehlcke
2017-05-02 6:53 ` Laxman Dewangan
2017-05-14 10:16 ` Mark Brown [this message]
2017-05-15 22:55 ` Matthias Kaehlcke
2017-05-02 6:51 ` [PATCH v2 1/2] regulator: DT: Add properties " Laxman Dewangan
2017-05-08 14:08 ` Rob Herring
2017-05-17 9:53 ` Applied "regulator: DT: Add properties for asymmetric settling times" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170514101652.waoc5fhjzpd2emoq@sirena.org.uk \
--to=broonie@kernel.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).