* [PATCH] staging: rtl8188eu: Fix one coding style problem
@ 2017-05-10 0:07 Remco Verhoef
2017-05-12 9:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Remco Verhoef @ 2017-05-10 0:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel; +Cc: Remco Verhoef
Fix code indent should use tabs where possible coding style
error.
Signed-off-by: Remco Verhoef <remco@dutchcoders.io>
---
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
index d9fa290..636f445 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
@@ -58,7 +58,7 @@ static void process_link_qual(struct adapter *padapter,
}
void rtl8188e_process_phy_info(struct adapter *padapter,
- struct recv_frame *precvframe)
+ struct recv_frame *precvframe)
{
/* Check RSSI */
process_rssi(padapter, precvframe);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: rtl8188eu: Fix one coding style problem
2017-05-10 0:07 [PATCH] staging: rtl8188eu: Fix one coding style problem Remco Verhoef
@ 2017-05-12 9:08 ` Greg Kroah-Hartman
2017-05-13 1:39 ` [PATCH v2] staging: rtl8188eu: fix indentation error Remco Verhoef
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-05-12 9:08 UTC (permalink / raw)
To: Remco Verhoef; +Cc: devel, linux-kernel
On Tue, May 09, 2017 at 05:07:51PM -0700, Remco Verhoef wrote:
> Fix code indent should use tabs where possible coding style
> error.
Your subject should be a bit better, why, "one"?
please fix and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: rtl8188eu: fix indentation error
2017-05-12 9:08 ` Greg Kroah-Hartman
@ 2017-05-13 1:39 ` Remco Verhoef
2017-05-15 10:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Remco Verhoef @ 2017-05-13 1:39 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel; +Cc: Remco Verhoef
Fixes a 'code indent should use tabs where possible' checkpatch code
style error by changing whitespace into tabs.
Signed-off-by: Remco Verhoef <remco@dutchcoders.io>
---
Changes in v2:
- More expressive commit message and subject
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
index d9fa290..636f445 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
@@ -58,7 +58,7 @@ static void process_link_qual(struct adapter *padapter,
}
void rtl8188e_process_phy_info(struct adapter *padapter,
- struct recv_frame *precvframe)
+ struct recv_frame *precvframe)
{
/* Check RSSI */
process_rssi(padapter, precvframe);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: rtl8188eu: fix indentation error
2017-05-13 1:39 ` [PATCH v2] staging: rtl8188eu: fix indentation error Remco Verhoef
@ 2017-05-15 10:50 ` Greg Kroah-Hartman
2017-05-15 20:37 ` [PATCH v3] " Remco Verhoef
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-05-15 10:50 UTC (permalink / raw)
To: Remco Verhoef; +Cc: devel, linux-kernel
On Fri, May 12, 2017 at 06:39:44PM -0700, Remco Verhoef wrote:
> Fixes a 'code indent should use tabs where possible' checkpatch code
> style error by changing whitespace into tabs.
>
> Signed-off-by: Remco Verhoef <remco@dutchcoders.io>
> ---
> Changes in v2:
> - More expressive commit message and subject
>
> drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
> index d9fa290..636f445 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
> @@ -58,7 +58,7 @@ static void process_link_qual(struct adapter *padapter,
> }
>
> void rtl8188e_process_phy_info(struct adapter *padapter,
> - struct recv_frame *precvframe)
> + struct recv_frame *precvframe)
Try putting this right under the other "struct" string, to line things
up better.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3] staging: rtl8188eu: fix indentation error
2017-05-15 10:50 ` Greg Kroah-Hartman
@ 2017-05-15 20:37 ` Remco Verhoef
0 siblings, 0 replies; 5+ messages in thread
From: Remco Verhoef @ 2017-05-15 20:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel; +Cc: Remco Verhoef
Fixes a 'code indent should use tabs where possible' checkpatch code
style error by changing whitespace into tabs.
Signed-off-by: Remco Verhoef <remco@dutchcoders.io>
---
Changes in v2:
- More expressive commit message and subject
Changes in v3:
- Align with struct, to line things up better
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
index d9fa290..9f51f54 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
@@ -58,7 +58,7 @@ static void process_link_qual(struct adapter *padapter,
}
void rtl8188e_process_phy_info(struct adapter *padapter,
- struct recv_frame *precvframe)
+ struct recv_frame *precvframe)
{
/* Check RSSI */
process_rssi(padapter, precvframe);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-15 20:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-10 0:07 [PATCH] staging: rtl8188eu: Fix one coding style problem Remco Verhoef
2017-05-12 9:08 ` Greg Kroah-Hartman
2017-05-13 1:39 ` [PATCH v2] staging: rtl8188eu: fix indentation error Remco Verhoef
2017-05-15 10:50 ` Greg Kroah-Hartman
2017-05-15 20:37 ` [PATCH v3] " Remco Verhoef
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).