From: Michal Hocko <mhocko@kernel.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH] drm: use kvmalloc_array for drm_malloc*
Date: Tue, 16 May 2017 12:53:52 +0200 [thread overview]
Message-ID: <20170516105352.GH2481@dhcp22.suse.cz> (raw)
In-Reply-To: <20170516093119.GW19912@nuc-i3427.alporthouse.com>
On Tue 16-05-17 10:31:19, Chris Wilson wrote:
> On Tue, May 16, 2017 at 11:06:06AM +0200, Michal Hocko wrote:
> > From: Michal Hocko <mhocko@suse.com>
> >
> > drm_malloc* has grown their own kmalloc with vmalloc fallback
> > implementations. MM has grown kvmalloc* helpers in the meantime. Let's
> > use those because it a) reduces the code and b) MM has a better idea
> > how to implement fallbacks (e.g. do not vmalloc before kmalloc is tried
> > with __GFP_NORETRY).
>
> Better? The same idea. The only difference I was reluctant to hand out
> large pages for long lived objects. If that's the wisdom of the core mm,
> so be it.
vmalloc tends to fragment physical memory more os it is preferable to
try the physically contiguous request first and only fall back to
vmalloc if the first attempt would be too costly or it fails.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-05-16 10:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 9:06 [PATCH] drm: use kvmalloc_array for drm_malloc* Michal Hocko
2017-05-16 9:22 ` Daniel Vetter
2017-05-16 9:52 ` Michal Hocko
2017-05-16 13:08 ` Daniel Vetter
2017-05-16 13:21 ` Michal Hocko
2017-05-16 9:31 ` Chris Wilson
2017-05-16 10:53 ` Michal Hocko [this message]
2017-05-16 11:09 ` Chris Wilson
2017-05-17 7:44 ` Michal Hocko
2017-05-17 7:59 ` Chris Wilson
2017-05-17 8:09 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516105352.GH2481@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).