* [PATCH] misc: pci_endpoint_test: select CONFIG_CRC32
@ 2017-05-11 12:13 Arnd Bergmann
2017-05-16 21:02 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-11 12:13 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: Kishon Vijay Abraham I, linux-kernel
Without CRC32, we get this link error:
pci_endpoint_test.c:(.text+0x2509e): undefined reference to `crc32_le'
Fixes: 58c89c8aa0e8 ("misc: Add host side PCI driver for PCI test function device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/misc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 2cba76e6fa3c..07bbd4cc1852 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -492,6 +492,7 @@ config ASPEED_LPC_CTRL
config PCI_ENDPOINT_TEST
depends on PCI
+ select CRC32
tristate "PCI Endpoint Test driver"
---help---
Enable this configuration option to enable the host side test driver
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] misc: pci_endpoint_test: select CONFIG_CRC32
2017-05-11 12:13 [PATCH] misc: pci_endpoint_test: select CONFIG_CRC32 Arnd Bergmann
@ 2017-05-16 21:02 ` Greg Kroah-Hartman
2017-05-17 7:51 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-05-16 21:02 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Kishon Vijay Abraham I, linux-kernel
On Thu, May 11, 2017 at 02:13:33PM +0200, Arnd Bergmann wrote:
> Without CRC32, we get this link error:
>
> pci_endpoint_test.c:(.text+0x2509e): undefined reference to `crc32_le'
>
> Fixes: 58c89c8aa0e8 ("misc: Add host side PCI driver for PCI test function device")
There is no such commit id :(
Also, I think someone else sent this a few days before you did...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] misc: pci_endpoint_test: select CONFIG_CRC32
2017-05-16 21:02 ` Greg Kroah-Hartman
@ 2017-05-17 7:51 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-17 7:51 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Kishon Vijay Abraham I, Linux Kernel Mailing List
On Tue, May 16, 2017 at 11:02 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, May 11, 2017 at 02:13:33PM +0200, Arnd Bergmann wrote:
>> Without CRC32, we get this link error:
>>
>> pci_endpoint_test.c:(.text+0x2509e): undefined reference to `crc32_le'
>>
>> Fixes: 58c89c8aa0e8 ("misc: Add host side PCI driver for PCI test function device")
>
> There is no such commit id :(
I checked what happened: 58c89c8aa0e8 was in linux-next when I prepared the
patch, but 2c156ac71c6b25 is the commit ID that was merged in the end
after Bjorn rebased the patch on Apr 28, but I had not sent out the fix at
that point yet.
> Also, I think someone else sent this a few days before you did...
Ok.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-17 7:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-11 12:13 [PATCH] misc: pci_endpoint_test: select CONFIG_CRC32 Arnd Bergmann
2017-05-16 21:02 ` Greg Kroah-Hartman
2017-05-17 7:51 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).