* [PATCH] frv: use generic fb.h
@ 2017-05-17 8:33 Tobias Klauser
2017-05-24 12:55 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2017-05-17 8:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: Matthias Kaehlcke, David Howells, linux-kernel
The arch uses a verbatim copy of the asm-generic version and does not
add any own implemntations to the header, so use asm-generic/fb.h
instead of duplicating code.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
arch/frv/include/asm/Kbuild | 1 +
arch/frv/include/asm/fb.h | 12 ------------
2 files changed, 1 insertion(+), 12 deletions(-)
delete mode 100644 arch/frv/include/asm/fb.h
diff --git a/arch/frv/include/asm/Kbuild b/arch/frv/include/asm/Kbuild
index cce3bc3603ea..7d4ab04c657f 100644
--- a/arch/frv/include/asm/Kbuild
+++ b/arch/frv/include/asm/Kbuild
@@ -2,6 +2,7 @@
generic-y += clkdev.h
generic-y += exec.h
generic-y += extable.h
+generic-y += fb.h
generic-y += irq_work.h
generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
diff --git a/arch/frv/include/asm/fb.h b/arch/frv/include/asm/fb.h
deleted file mode 100644
index c7df38030992..000000000000
--- a/arch/frv/include/asm/fb.h
+++ /dev/null
@@ -1,12 +0,0 @@
-#ifndef _ASM_FB_H_
-#define _ASM_FB_H_
-#include <linux/fb.h>
-
-#define fb_pgprotect(...) do {} while (0)
-
-static inline int fb_is_primary_device(struct fb_info *info)
-{
- return 0;
-}
-
-#endif /* _ASM_FB_H_ */
--
2.13.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] frv: use generic fb.h
2017-05-17 8:33 [PATCH] frv: use generic fb.h Tobias Klauser
@ 2017-05-24 12:55 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2017-05-24 12:55 UTC (permalink / raw)
To: Tobias Klauser; +Cc: dhowells, Andrew Morton, Matthias Kaehlcke, linux-kernel
Tobias Klauser <tklauser@distanz.ch> wrote:
> The arch uses a verbatim copy of the asm-generic version and does not
> add any own implemntations to the header, so use asm-generic/fb.h
> instead of duplicating code.
"implementations". This goes for the mn10300 patch also.
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Reviewed-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-24 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 8:33 [PATCH] frv: use generic fb.h Tobias Klauser
2017-05-24 12:55 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).