From: Wei Yang <richard.weiyang@gmail.com>
To: cl@linux.com, penberg@kernel.org, rientjes@google.com,
akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 2/6] mm/slub: not include cpu_partial data in cpu_slabs sysfs
Date: Wed, 17 May 2017 22:11:42 +0800 [thread overview]
Message-ID: <20170517141146.11063-3-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20170517141146.11063-1-richard.weiyang@gmail.com>
There are four level slabs:
CPU
CPU_PARTIAL
PARTIAL
FULL
In current implementation, cpu_slabs sysfs would give statistics including
the first two levels. While there is another sysfs entry cpu_partial_slabs
gives details on the second level slab statistics. Since each cpu has one
slab for the first level, the current cpu_slabs output is easy to be
calculated from cpu_partial_slabs.
This patch removes the cpu_partial data in cpu_slabs for more specific slab
statistics and leave room to retrieve objects and total objects on CPU
level in the future.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
mm/slub.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 1100d2e75870..c7dddf22829d 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -4762,19 +4762,6 @@ static ssize_t show_slab_objects(struct kmem_cache *s,
total += x;
nodes[node] += x;
-
- page = slub_percpu_partial_read_once(c);
- if (page) {
- node = page_to_nid(page);
- if (flags & SO_TOTAL)
- WARN_ON_ONCE(1);
- else if (flags & SO_OBJECTS)
- WARN_ON_ONCE(1);
- else
- x = page->pages;
- total += x;
- nodes[node] += x;
- }
}
}
--
2.11.0
next prev parent reply other threads:[~2017-05-17 14:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 14:11 [PATCH 0/6] refine and rename slub sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 1/6] mm/slub: add total_objects_partial sysfs Wei Yang
2017-05-17 14:50 ` Christoph Lameter
2017-05-17 14:11 ` Wei Yang [this message]
2017-05-17 14:11 ` [PATCH 3/6] mm/slub: add cpu_slabs_[total_]objects sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 4/6] mm/slub: rename ALL slabs sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 5/6] mm/slub: rename partial_slabs sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 6/6] mm/slub: rename cpu_partial_slab sysfs Wei Yang
2017-05-17 14:57 ` [PATCH 0/6] refine and rename slub sysfs Christoph Lameter
2017-05-18 9:06 ` Michal Hocko
2017-05-23 3:27 ` Wei Yang
2017-05-23 6:39 ` Michal Hocko
2017-05-23 16:07 ` Christoph Lameter
2017-05-24 9:54 ` Wei Yang
2017-05-24 12:03 ` Michal Hocko
2017-05-24 15:21 ` Wei Yang
2017-05-24 16:03 ` Christoph Lameter
2017-05-25 6:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170517141146.11063-3-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).