From: Christoph Lameter <cl@linux.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: Michal Hocko <mhocko@kernel.org>,
penberg@kernel.org, rientjes@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] refine and rename slub sysfs
Date: Wed, 24 May 2017 11:03:58 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1705241101090.24771@east.gentwo.org> (raw)
In-Reply-To: <20170524152124.GB8445@WeideMacBook-Pro.local>
On Wed, 24 May 2017, Wei Yang wrote:
> >
> >Who is going to use those new entries and for what purpose? Why do we
> >want to expose even more details of the slab allocator to the userspace.
> >Is the missing information something fundamental that some user space
> >cannot work without it? Seriously these are essential questions you
> >should have answer for _before_ posting the patch and mention all those
> >reasons in the changelog.
>
> It is me who wants to get more details of the slub behavior.
> AFAIK, no one else is expecting this.
I would appreciate some clearer structured statistics. These are important
for diagnostics and for debugging. Do not go overboard with this. Respin
it and provide also a cleanup of the slabinfo tool? I would appreciate it.
> Hmm, if we really don't want to export these entries, why not remove related
> code? Looks we are sure they will not be touched.
Please have a look at the slabinfo code which depends on those fields in
order to display slab information. I have patchsets here that will add
more functionality to slab and those will also add additional fields to
sysfs.
next prev parent reply other threads:[~2017-05-24 16:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 14:11 [PATCH 0/6] refine and rename slub sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 1/6] mm/slub: add total_objects_partial sysfs Wei Yang
2017-05-17 14:50 ` Christoph Lameter
2017-05-17 14:11 ` [PATCH 2/6] mm/slub: not include cpu_partial data in cpu_slabs sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 3/6] mm/slub: add cpu_slabs_[total_]objects sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 4/6] mm/slub: rename ALL slabs sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 5/6] mm/slub: rename partial_slabs sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 6/6] mm/slub: rename cpu_partial_slab sysfs Wei Yang
2017-05-17 14:57 ` [PATCH 0/6] refine and rename slub sysfs Christoph Lameter
2017-05-18 9:06 ` Michal Hocko
2017-05-23 3:27 ` Wei Yang
2017-05-23 6:39 ` Michal Hocko
2017-05-23 16:07 ` Christoph Lameter
2017-05-24 9:54 ` Wei Yang
2017-05-24 12:03 ` Michal Hocko
2017-05-24 15:21 ` Wei Yang
2017-05-24 16:03 ` Christoph Lameter [this message]
2017-05-25 6:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1705241101090.24771@east.gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penberg@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).