linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM
@ 2017-05-17 21:19 Arnd Bergmann
  2017-05-18  2:25 ` Chen-Yu Tsai
  0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-17 21:19 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: Arnd Bergmann, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng,
	linux-arm-kernel, linux-clk, linux-kernel

The newly added PRCM CCU driver uses SUNXI_CCU_MP_WITH_MUX_GATE, which causes
a link error when no other driver enables SUNXI_CCU_MP:

drivers/clk/built-in.o:(.data+0x5c8c8): undefined reference to `ccu_mp_ops'

This adds an explicit 'select' statement for it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/sunxi-ng/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index b0d551a8efe4..eb89c7801f00 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -156,6 +156,7 @@ config SUN8I_R_CCU
 	bool "Support for Allwinner SoCs' PRCM CCUs"
 	select SUNXI_CCU_DIV
 	select SUNXI_CCU_GATE
+	select SUNXI_CCU_MP
 	default MACH_SUN8I || (ARCH_SUNXI && ARM64)
 
 endif
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM
  2017-05-17 21:19 [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM Arnd Bergmann
@ 2017-05-18  2:25 ` Chen-Yu Tsai
  2017-05-18  6:49   ` Maxime Ripard
  0 siblings, 1 reply; 3+ messages in thread
From: Chen-Yu Tsai @ 2017-05-18  2:25 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Michael Turquette, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
	Icenowy Zheng, linux-arm-kernel, linux-clk, linux-kernel

On Thu, May 18, 2017 at 5:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added PRCM CCU driver uses SUNXI_CCU_MP_WITH_MUX_GATE, which causes
> a link error when no other driver enables SUNXI_CCU_MP:
>
> drivers/clk/built-in.o:(.data+0x5c8c8): undefined reference to `ccu_mp_ops'
>
> This adds an explicit 'select' statement for it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Chen-Yu Tsai <wens@csie.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM
  2017-05-18  2:25 ` Chen-Yu Tsai
@ 2017-05-18  6:49   ` Maxime Ripard
  0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2017-05-18  6:49 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Arnd Bergmann, Michael Turquette, Stephen Boyd, Icenowy Zheng,
	linux-arm-kernel, linux-clk, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

On Thu, May 18, 2017 at 10:25:23AM +0800, Chen-Yu Tsai wrote:
> On Thu, May 18, 2017 at 5:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The newly added PRCM CCU driver uses SUNXI_CCU_MP_WITH_MUX_GATE, which causes
> > a link error when no other driver enables SUNXI_CCU_MP:
> >
> > drivers/clk/built-in.o:(.data+0x5c8c8): undefined reference to `ccu_mp_ops'
> >
> > This adds an explicit 'select' statement for it.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-18  6:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 21:19 [PATCH] clk: sunxi-ng: enable SUNXI_CCU_MP for PRCM Arnd Bergmann
2017-05-18  2:25 ` Chen-Yu Tsai
2017-05-18  6:49   ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).