linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH] fput: Don't reinvent the wheel but use existing llist API
@ 2017-05-12  0:39 Byungchul Park
  2017-05-18  2:02 ` Byungchul Park
  0 siblings, 1 reply; 4+ messages in thread
From: Byungchul Park @ 2017-05-12  0:39 UTC (permalink / raw)
  To: viro; +Cc: linux-kernel, kernel-team

Although llist provides proper APIs, they are not used. Make them used.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
---
 fs/file_table.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/fs/file_table.c b/fs/file_table.c
index 6d982b5..3209da2 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -231,12 +231,10 @@ static void __fput(struct file *file)
 static void delayed_fput(struct work_struct *unused)
 {
 	struct llist_node *node = llist_del_all(&delayed_fput_list);
-	struct llist_node *next;
+	struct file *f, *t;
 
-	for (; node; node = next) {
-		next = llist_next(node);
-		__fput(llist_entry(node, struct file, f_u.fu_llist));
-	}
+	llist_for_each_entry_safe(f, t, node, f_u.fu_llist)
+		__fput(f);
 }
 
 static void ____fput(struct callback_head *work)
@@ -310,7 +308,7 @@ void put_filp(struct file *file)
 }
 
 void __init files_init(void)
-{ 
+{
 	filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0,
 			SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL);
 	percpu_counter_init(&nr_files, 0, GFP_KERNEL);
@@ -329,4 +327,4 @@ void __init files_maxfiles_init(void)
 	n = ((totalram_pages - memreserve) * (PAGE_SIZE / 1024)) / 10;
 
 	files_stat.max_files = max_t(unsigned long, n, NR_FILE);
-} 
+}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [RESEND PATCH] Don't reinvent the wheel but use existing llilst API
@ 2017-07-10  2:37 Byungchul Park
  2017-07-10  2:37 ` [RESEND PATCH] fput: Don't reinvent the wheel but use existing llist API Byungchul Park
  0 siblings, 1 reply; 4+ messages in thread
From: Byungchul Park @ 2017-07-10  2:37 UTC (permalink / raw)
  To: torvalds; +Cc: axboe, viro, linux-kernel, kernel-team

Hello Linus,

Even though llist APIs exist, serveral code in kernel reinvent the
implementation again and again. Since I think it's *worth* making it use
existing APIs, I submit patches doing it.

Actually I've submitted them to maintainers and commiters about 10 times
for 4 months, but they seem to be too busy to review or take them. Of
course you might be even busier, but it would be appriciated if you do
that instead. It might not take your time much since they are simple.

Patches worked on scheduler, irq_work, vhost/scsi and raid are already
taken by proper maintainers. For now, only ones for bcache, mm, fput and
namespace remain.

Thank you,
Byungchul

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [RESEND PATCH] fput: Don't reinvent the wheel but use existing llist API
@ 2017-08-07  8:45 Byungchul Park
  0 siblings, 0 replies; 4+ messages in thread
From: Byungchul Park @ 2017-08-07  8:45 UTC (permalink / raw)
  To: viro; +Cc: linux-fsdevel, linux-kernel, kernel-team

Although llist provides proper APIs, they are not used. Make them used.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
---
 fs/file_table.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/fs/file_table.c b/fs/file_table.c
index 6d982b5..3209da2 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -231,12 +231,10 @@ static void __fput(struct file *file)
 static void delayed_fput(struct work_struct *unused)
 {
 	struct llist_node *node = llist_del_all(&delayed_fput_list);
-	struct llist_node *next;
+	struct file *f, *t;
 
-	for (; node; node = next) {
-		next = llist_next(node);
-		__fput(llist_entry(node, struct file, f_u.fu_llist));
-	}
+	llist_for_each_entry_safe(f, t, node, f_u.fu_llist)
+		__fput(f);
 }
 
 static void ____fput(struct callback_head *work)
@@ -310,7 +308,7 @@ void put_filp(struct file *file)
 }
 
 void __init files_init(void)
-{ 
+{
 	filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0,
 			SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL);
 	percpu_counter_init(&nr_files, 0, GFP_KERNEL);
@@ -329,4 +327,4 @@ void __init files_maxfiles_init(void)
 	n = ((totalram_pages - memreserve) * (PAGE_SIZE / 1024)) / 10;
 
 	files_stat.max_files = max_t(unsigned long, n, NR_FILE);
-} 
+}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-07  8:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12  0:39 [RESEND PATCH] fput: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-05-18  2:02 ` Byungchul Park
2017-07-10  2:37 [RESEND PATCH] Don't reinvent the wheel but use existing llilst API Byungchul Park
2017-07-10  2:37 ` [RESEND PATCH] fput: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-08-07  8:45 Byungchul Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).