From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: "Latif, Faisal" <faisal.latif@intel.com>,
Doug Ledford <dledford@redhat.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [infiniband-hw-i40iw] question about identical code for different branches
Date: Thu, 18 May 2017 12:54:13 -0500 [thread overview]
Message-ID: <20170518125413.Horde.xnD_6K5mFzkhQLdyz7R3LXt@gator4166.hostgator.com> (raw)
In-Reply-To: <9DD61F30A802C4429A01CA4200E302A730338947@fmsmsx116.amr.corp.intel.com>
Quoting "Saleem, Shiraz" <shiraz.saleem@intel.com>:
>> Subject: [infiniband-hw-i40iw] question about identical code for
>> different branches
>>
>>
>> index f4d1368..48fd327 100644
>> --- a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
>> +++ b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
>> @@ -443,10 +443,7 @@ enum i40iw_status_code i40iw_vchnl_recv_pf(struct
>> i40iw_sc_dev *dev,
>> if (!dev->vchnl_up)
>> return I40IW_ERR_NOT_READY;
>> if (vchnl_msg->iw_op_code == I40IW_VCHNL_OP_GET_VER) {
>> - if (vchnl_msg->iw_op_ver != I40IW_VCHNL_OP_GET_VER_V0)
>> - vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
>> - else
>> - vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
>> + vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
>> return I40IW_SUCCESS;
>> }
>> for (iw_vf_idx = 0; iw_vf_idx < I40IW_MAX_PE_ENABLED_VF_COUNT;
>> iw_vf_idx++) {
>>
>> What do you think?
>>
>> I'd really appreciate any comment on this.
>>
> Yes. This fix is fine.
>
I'll send a patch in a full and proper format shortly.
Thank you all for your comments.
--
Gustavo A. R. Silva
next prev parent reply other threads:[~2017-05-18 17:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 22:06 [infiniband-hw-i40iw] question about identical code for different branches Gustavo A. R. Silva
2017-05-18 5:00 ` Leon Romanovsky
2017-05-18 15:03 ` Chien Tin Tung
2017-05-18 6:00 ` Yuval Shaia
2017-05-18 14:35 ` Saleem, Shiraz
2017-05-18 17:54 ` Gustavo A. R. Silva [this message]
2017-05-18 18:11 ` [PATCH] infiniband: hw: i40iw: fix duplicated " Gustavo A. R. Silva
2017-05-19 16:59 ` Shiraz Saleem
2017-06-01 22:27 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518125413.Horde.xnD_6K5mFzkhQLdyz7R3LXt@gator4166.hostgator.com \
--to=garsilva@embeddedor.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).