* [PATCH] ARM: at91: select CONFIG_ARM_CPU_SUSPEND
@ 2017-05-18 14:41 Arnd Bergmann
2017-05-23 12:57 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2017-05-18 14:41 UTC (permalink / raw)
To: Nicolas Ferre, Alexandre Belloni
Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel
The reference to cpu_resume requires the corresponding
generic code to be enabled when CONFIG_PM is set:
arch/arm/mach-at91/pm.o: In function `sama5d2_pm_init':
pm.c:(.init.text+0x5e8): undefined reference to `cpu_resume'
Fixes: 24a0f5c539f9 ("ARM: at91: pm: Add sama5d2 backup mode")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-at91/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index e754efd0016e..af76234d60c8 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -1,6 +1,7 @@
menuconfig ARCH_AT91
bool "Atmel SoCs"
depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
+ select ARM_CPU_SUSPEND if PM
select COMMON_CLK_AT91
select GPIOLIB
select PINCTRL
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: at91: select CONFIG_ARM_CPU_SUSPEND
2017-05-18 14:41 [PATCH] ARM: at91: select CONFIG_ARM_CPU_SUSPEND Arnd Bergmann
@ 2017-05-23 12:57 ` Alexandre Belloni
2017-05-24 15:39 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2017-05-23 12:57 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Nicolas Ferre, linux-arm-kernel, linux-kernel
Hi,
On 18/05/2017 at 16:41:29 +0200, Arnd Bergmann wrote:
> The reference to cpu_resume requires the corresponding
> generic code to be enabled when CONFIG_PM is set:
>
> arch/arm/mach-at91/pm.o: In function `sama5d2_pm_init':
> pm.c:(.init.text+0x5e8): undefined reference to `cpu_resume'
>
> Fixes: 24a0f5c539f9 ("ARM: at91: pm: Add sama5d2 backup mode")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-at91/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index e754efd0016e..af76234d60c8 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -1,6 +1,7 @@
> menuconfig ARCH_AT91
> bool "Atmel SoCs"
> depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
> + select ARM_CPU_SUSPEND if PM
This does not apply on v4.12-rc1 because the depends are different.
> select COMMON_CLK_AT91
> select GPIOLIB
> select PINCTRL
> --
> 2.9.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: at91: select CONFIG_ARM_CPU_SUSPEND
2017-05-23 12:57 ` Alexandre Belloni
@ 2017-05-24 15:39 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-05-24 15:39 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Nicolas Ferre, Linux ARM, Linux Kernel Mailing List
On Tue, May 23, 2017 at 2:57 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Hi,
>
> On 18/05/2017 at 16:41:29 +0200, Arnd Bergmann wrote:
>> The reference to cpu_resume requires the corresponding
>> generic code to be enabled when CONFIG_PM is set:
>>
>> arch/arm/mach-at91/pm.o: In function `sama5d2_pm_init':
>> pm.c:(.init.text+0x5e8): undefined reference to `cpu_resume'
>>
>> Fixes: 24a0f5c539f9 ("ARM: at91: pm: Add sama5d2 backup mode")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> arch/arm/mach-at91/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
>> index e754efd0016e..af76234d60c8 100644
>> --- a/arch/arm/mach-at91/Kconfig
>> +++ b/arch/arm/mach-at91/Kconfig
>> @@ -1,6 +1,7 @@
>> menuconfig ARCH_AT91
>> bool "Atmel SoCs"
>> depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
>> + select ARM_CPU_SUSPEND if PM
>
> This does not apply on v4.12-rc1 because the depends are different.
Sent a new version now.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: at91: select CONFIG_ARM_CPU_SUSPEND
2017-05-24 15:39 Arnd Bergmann
@ 2017-05-29 9:18 ` Alexandre Belloni
0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2017-05-29 9:18 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Nicolas Ferre, linux-arm-kernel, linux-kernel
On 24/05/2017 at 17:39:03 +0200, Arnd Bergmann wrote:
> The reference to cpu_resume requires the corresponding
> generic code to be enabled when CONFIG_PM is set:
>
> arch/arm/mach-at91/pm.o: In function `sama5d2_pm_init':
> pm.c:(.init.text+0x5e8): undefined reference to `cpu_resume'
>
> Fixes: 24a0f5c539f9 ("ARM: at91: pm: Add sama5d2 backup mode")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-at91/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91: select CONFIG_ARM_CPU_SUSPEND
@ 2017-05-24 15:39 Arnd Bergmann
2017-05-29 9:18 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2017-05-24 15:39 UTC (permalink / raw)
To: Nicolas Ferre, Alexandre Belloni
Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel
The reference to cpu_resume requires the corresponding
generic code to be enabled when CONFIG_PM is set:
arch/arm/mach-at91/pm.o: In function `sama5d2_pm_init':
pm.c:(.init.text+0x5e8): undefined reference to `cpu_resume'
Fixes: 24a0f5c539f9 ("ARM: at91: pm: Add sama5d2 backup mode")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-at91/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 841e924143f9..cbd959b73654 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -1,6 +1,7 @@
menuconfig ARCH_AT91
bool "Atmel SoCs"
depends on ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V7
+ select ARM_CPU_SUSPEND if PM
select COMMON_CLK_AT91
select GPIOLIB
select PINCTRL
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-29 9:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 14:41 [PATCH] ARM: at91: select CONFIG_ARM_CPU_SUSPEND Arnd Bergmann
2017-05-23 12:57 ` Alexandre Belloni
2017-05-24 15:39 ` Arnd Bergmann
2017-05-24 15:39 Arnd Bergmann
2017-05-29 9:18 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).