* [PATCH] r8152: Remove unused function usb_ocp_read()
@ 2017-05-18 17:45 Matthias Kaehlcke
2017-05-18 18:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Kaehlcke @ 2017-05-18 17:45 UTC (permalink / raw)
To: David S . Miller, hayeswang
Cc: linux-usb, netdev, linux-kernel, Matthias Kaehlcke
The function is not used, removing it fixes the following warning when
building with clang:
drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read'
[-Werror,-Wunused-function]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/net/usb/r8152.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index ddc62cb69be8..e902df9595b9 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -841,12 +841,6 @@ int pla_ocp_write(struct r8152 *tp, u16 index, u16 byteen, u16 size, void *data)
}
static inline
-int usb_ocp_read(struct r8152 *tp, u16 index, u16 size, void *data)
-{
- return generic_ocp_read(tp, index, size, data, MCU_TYPE_USB);
-}
-
-static inline
int usb_ocp_write(struct r8152 *tp, u16 index, u16 byteen, u16 size, void *data)
{
return generic_ocp_write(tp, index, byteen, size, data, MCU_TYPE_USB);
--
2.13.0.303.g4ebf302169-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] r8152: Remove unused function usb_ocp_read()
2017-05-18 17:45 [PATCH] r8152: Remove unused function usb_ocp_read() Matthias Kaehlcke
@ 2017-05-18 18:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-05-18 18:46 UTC (permalink / raw)
To: mka; +Cc: hayeswang, linux-usb, netdev, linux-kernel
From: Matthias Kaehlcke <mka@chromium.org>
Date: Thu, 18 May 2017 10:45:33 -0700
> The function is not used, removing it fixes the following warning when
> building with clang:
>
> drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read'
> [-Werror,-Wunused-function]
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-18 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 17:45 [PATCH] r8152: Remove unused function usb_ocp_read() Matthias Kaehlcke
2017-05-18 18:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).