From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Pascal Wichmann <pascal.wichmann@pa-w.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices"
Date: Sat, 20 May 2017 10:35:26 -0700 [thread overview]
Message-ID: <20170520173526.GB38800@dtor-ws> (raw)
In-Reply-To: <20170520095950.GB6808@mail.corp.redhat.com>
On Sat, May 20, 2017 at 11:59:50AM +0200, Benjamin Tissoires wrote:
> Hi,
>
> On May 20 2017 or thereabouts, Pascal Wichmann wrote:
> > > Looks like you running your patched kernel?
> > That's right.
> >
> >
> > >>> CONFIG_RMI4_CORE=m
> > >>> CONFIG_RMI4_I2C=m
> > >>> CONFIG_RMI4_SPI=m
> > >>> # CONFIG_RMI4_SMB is not set
> > >
> > > This is your issue I believe.
> >
> > Indeed, enabling that configuration solves that issue.
> >
> > However, I think it is quite unintuitive that a module (psmouse) chooses
> > a default mode which requires another driver which is not necessarily
> > included; though it would probably be not a very clean solution to
> > explicitly check that as well.
> >
> > Is this behaviour, that one module requires another without
> > communicating that clearly, wanted?
> >
>
> I can see 3 solutions:
> 1. Have PS2_SMBUS depending on RMI_SMBUS (and ELAN_I2C, and others when
> required)
> 2. Have PS2_SMBUS selecting RMI_SMBUS (and the others when time comes)
> 3. Changing the default value of synaptics_intertouch to
> SYNAPTICS_INTERTOUCH_OFF when RMI_SMBUS is not set
>
> Solution 3. might be interesting because it doesn't prevent users to
> compile the module on the side and is Synaptics only.
>
> Dmitry, any comments?
I like #3. We might also want to stick a warning into synaptics.c when
we see a device that has intertouch, but RMI_SMBUS is disabled, so we
could nudge users to switch over to RMI.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-05-20 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 18:46 [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices" Pascal Wichmann
2017-05-19 19:08 ` Dmitry Torokhov
2017-05-19 19:37 ` Pascal Wichmann
2017-05-19 20:23 ` Dmitry Torokhov
2017-05-19 20:35 ` Pascal Wichmann
2017-05-19 20:49 ` Dmitry Torokhov
2017-05-20 5:47 ` Pascal Wichmann
2017-05-20 9:59 ` Benjamin Tissoires
2017-05-20 17:35 ` Dmitry Torokhov [this message]
2017-05-23 8:33 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170520173526.GB38800@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pascal.wichmann@pa-w.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).