linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pascal Wichmann <pascal.wichmann@pa-w.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices"
Date: Fri, 19 May 2017 20:46:16 +0200	[thread overview]
Message-ID: <41de7f92-8d98-3266-5d28-28ba48c5da38@pa-w.de> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1346 bytes --]

Hello,

using the latest 4.12-rc1 kernel, the trackpoint and touchpad of my
Thinkpad X250 are not recognized.

This is caused by commit
e839ffa  Input: synaptics - add support for Intertouch devices


The specific problem seems to be the detection of whether to use
synaptics_intertouch for the psmouse module or not. That parameter
is set to -1 by default, in which case synaptics_intertouch is
enabled on my device.

When I explicitly set that parameter to 0, the trackpoint and touchpad
are recognized and work as expected.

Removing my device from smbus_pnp_ids in 4.12 rc1 fixes the issue
without need to manually disable synaptics_intertouch in the psmouse
module:

diff -ruN a/drivers/input/mouse/synaptics.c
b/drivers/input/mouse/synaptics.c
--- a/drivers/input/mouse/synaptics.c	2017-05-19 19:31:48.930734395 +0200
+++ b/drivers/input/mouse/synaptics.c	2017-05-19 19:32:00.490782484 +0200
@@ -170,7 +170,6 @@
 static const char * const smbus_pnp_ids[] = {
 	/* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
 	"LEN0048", /* X1 Carbon 3 */
-	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
 	"LEN200f", /* T450s */
 	NULL


Is the ThinkPad X250 not supporting intertouch or is there another
problem causing the input devices not to work with it enabled?


Regards,
Pascal



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2017-05-19 18:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 18:46 Pascal Wichmann [this message]
2017-05-19 19:08 ` [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices" Dmitry Torokhov
2017-05-19 19:37   ` Pascal Wichmann
2017-05-19 20:23     ` Dmitry Torokhov
2017-05-19 20:35       ` Pascal Wichmann
2017-05-19 20:49         ` Dmitry Torokhov
2017-05-20  5:47           ` Pascal Wichmann
2017-05-20  9:59             ` Benjamin Tissoires
2017-05-20 17:35               ` Dmitry Torokhov
2017-05-23  8:33                 ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41de7f92-8d98-3266-5d28-28ba48c5da38@pa-w.de \
    --to=pascal.wichmann@pa-w.de \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).