From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: Re: [PATCH 1/3] mfd: dm355evm_msp: move header file out of I2C realm
Date: Mon, 22 May 2017 11:14:38 +0200 [thread overview]
Message-ID: <20170522091438.mnomqfixxbzly75u@piout.net> (raw)
In-Reply-To: <20170521220212.1404-2-wsa@the-dreams.de>
On 22/05/2017 at 00:02:08 +0200, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/input/misc/dm355evm_keys.c | 2 +-
> drivers/mfd/dm355evm_msp.c | 2 +-
> drivers/rtc/rtc-dm355evm.c | 2 +-
> include/linux/{i2c => mfd}/dm355evm_msp.h | 0
> 4 files changed, 3 insertions(+), 3 deletions(-)
> rename include/linux/{i2c => mfd}/dm355evm_msp.h (100%)
>
> diff --git a/drivers/input/misc/dm355evm_keys.c b/drivers/input/misc/dm355evm_keys.c
> index bab256ef32b9b3..c803db64a3760d 100644
> --- a/drivers/input/misc/dm355evm_keys.c
> +++ b/drivers/input/misc/dm355evm_keys.c
> @@ -15,7 +15,7 @@
> #include <linux/platform_device.h>
> #include <linux/interrupt.h>
>
> -#include <linux/i2c/dm355evm_msp.h>
> +#include <linux/mfd/dm355evm_msp.h>
> #include <linux/module.h>
>
>
> diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
> index 86eca614507bd8..2a2756709f22f0 100644
> --- a/drivers/mfd/dm355evm_msp.c
> +++ b/drivers/mfd/dm355evm_msp.c
> @@ -18,7 +18,7 @@
> #include <linux/gpio.h>
> #include <linux/leds.h>
> #include <linux/i2c.h>
> -#include <linux/i2c/dm355evm_msp.h>
> +#include <linux/mfd/dm355evm_msp.h>
>
>
> /*
> diff --git a/drivers/rtc/rtc-dm355evm.c b/drivers/rtc/rtc-dm355evm.c
> index f225cd873ff6c2..97d8259b94940f 100644
> --- a/drivers/rtc/rtc-dm355evm.c
> +++ b/drivers/rtc/rtc-dm355evm.c
> @@ -13,7 +13,7 @@
> #include <linux/rtc.h>
> #include <linux/platform_device.h>
>
> -#include <linux/i2c/dm355evm_msp.h>
> +#include <linux/mfd/dm355evm_msp.h>
> #include <linux/module.h>
>
>
> diff --git a/include/linux/i2c/dm355evm_msp.h b/include/linux/mfd/dm355evm_msp.h
> similarity index 100%
> rename from include/linux/i2c/dm355evm_msp.h
> rename to include/linux/mfd/dm355evm_msp.h
> --
> 2.11.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-22 9:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 22:02 [PATCH 0/3] mfd: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 22:02 ` [PATCH 1/3] mfd: dm355evm_msp: move header file out of I2C realm Wolfram Sang
2017-05-22 9:14 ` Alexandre Belloni [this message]
2017-05-22 23:36 ` Dmitry Torokhov
2017-05-23 7:17 ` Lee Jones
2017-08-13 13:34 ` Wolfram Sang
2017-08-14 6:43 ` Lee Jones
2017-08-14 8:25 ` Wolfram Sang
2017-05-21 22:02 ` [PATCH 2/3] mfd: tps65010: " Wolfram Sang
2017-05-22 7:24 ` Greg Kroah-Hartman
2017-05-22 7:34 ` Krzysztof Kozlowski
2017-05-23 7:18 ` Lee Jones
2017-08-13 13:34 ` Wolfram Sang
2017-08-14 6:43 ` Lee Jones
2017-08-14 8:44 ` Lee Jones
2017-08-14 16:21 ` Tony Lindgren
2017-08-14 16:29 ` Wolfram Sang
2017-05-29 9:19 ` Bartlomiej Zolnierkiewicz
2017-05-21 22:02 ` [PATCH 3/3] mfd: twl: " Wolfram Sang
2017-05-22 7:25 ` Greg Kroah-Hartman
2017-05-22 9:14 ` Alexandre Belloni
2017-05-22 9:52 ` Mark Brown
2017-05-22 10:28 ` Wolfram Sang
2017-05-22 11:12 ` Mark Brown
2017-05-22 10:27 ` Sebastian Reichel
2017-05-22 20:34 ` Jonathan Cameron
2017-05-22 23:37 ` Dmitry Torokhov
2017-05-23 7:16 ` Lee Jones
2017-05-23 7:21 ` Wolfram Sang
2017-05-23 7:42 ` Kishon Vijay Abraham I
2017-05-29 9:20 ` Bartlomiej Zolnierkiewicz
2017-07-06 6:44 ` Thierry Reding
2017-07-06 7:03 ` Lee Jones
2017-08-13 13:37 ` Wolfram Sang
2017-08-14 6:42 ` Lee Jones
2017-08-14 8:43 ` Wolfram Sang
2017-08-14 16:22 ` Tony Lindgren
2017-08-14 16:27 ` Daniel Thompson
2017-08-14 16:32 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522091438.mnomqfixxbzly75u@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).