From: Lee Jones <lee.jones@linaro.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/3] mfd: tps65010: move header file out of I2C realm
Date: Tue, 23 May 2017 08:18:19 +0100 [thread overview]
Message-ID: <20170523071819.4zpdef7ofzz3moil@dell> (raw)
In-Reply-To: <20170521220212.1404-3-wsa@the-dreams.de>
On Mon, 22 May 2017, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> arch/arm/mach-omap1/board-h2-mmc.c | 2 +-
> arch/arm/mach-omap1/board-h2.c | 2 +-
> arch/arm/mach-omap1/board-h3-mmc.c | 2 +-
> arch/arm/mach-omap1/board-h3.c | 2 +-
> arch/arm/mach-omap1/board-osk.c | 2 +-
> arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 2 +-
> arch/arm/mach-s3c24xx/mach-osiris.c | 2 +-
> drivers/mfd/tps65010.c | 2 +-
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> drivers/usb/host/ohci-omap.c | 2 +-
> drivers/usb/phy/phy-isp1301-omap.c | 2 +-
> drivers/video/fbdev/omap/lcd_h3.c | 2 +-
> include/linux/{i2c => mfd}/tps65010.h | 2 +-
> 12 files changed, 12 insertions(+), 12 deletions(-)
> rename include/linux/{i2c => mfd}/tps65010.h (99%)
>
> diff --git a/arch/arm/mach-omap1/board-h2-mmc.c b/arch/arm/mach-omap1/board-h2-mmc.c
> index 357be2debc9da8..91bda9c802ff38 100644
> --- a/arch/arm/mach-omap1/board-h2-mmc.c
> +++ b/arch/arm/mach-omap1/board-h2-mmc.c
> @@ -14,7 +14,7 @@
> #include <linux/gpio.h>
> #include <linux/platform_device.h>
> #include <linux/platform_data/gpio-omap.h>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
>
> #include "board-h2.h"
> #include "mmc.h"
> diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c
> index 675254ee4b1e93..dece47d76282ac 100644
> --- a/arch/arm/mach-omap1/board-h2.c
> +++ b/arch/arm/mach-omap1/board-h2.c
> @@ -28,7 +28,7 @@
> #include <linux/mtd/partitions.h>
> #include <linux/mtd/physmap.h>
> #include <linux/input.h>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
> #include <linux/smc91x.h>
> #include <linux/omapfb.h>
> #include <linux/platform_data/gpio-omap.h>
> diff --git a/arch/arm/mach-omap1/board-h3-mmc.c b/arch/arm/mach-omap1/board-h3-mmc.c
> index 4f58bfa5e7549e..692c267a9a9052 100644
> --- a/arch/arm/mach-omap1/board-h3-mmc.c
> +++ b/arch/arm/mach-omap1/board-h3-mmc.c
> @@ -14,7 +14,7 @@
> #include <linux/gpio.h>
> #include <linux/platform_device.h>
>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
>
> #include "common.h"
> #include "board-h3.h"
> diff --git a/arch/arm/mach-omap1/board-h3.c b/arch/arm/mach-omap1/board-h3.c
> index e62f9d454f1005..6d32beeb2d8857 100644
> --- a/arch/arm/mach-omap1/board-h3.c
> +++ b/arch/arm/mach-omap1/board-h3.c
> @@ -28,7 +28,7 @@
> #include <linux/mtd/physmap.h>
> #include <linux/input.h>
> #include <linux/spi/spi.h>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
> #include <linux/smc91x.h>
> #include <linux/omapfb.h>
> #include <linux/platform_data/gpio-omap.h>
> diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c
> index 4dfb995048103b..f20361b8ffb6e0 100644
> --- a/arch/arm/mach-omap1/board-osk.c
> +++ b/arch/arm/mach-omap1/board-osk.c
> @@ -38,7 +38,7 @@
> #include <linux/mtd/mtd.h>
> #include <linux/mtd/partitions.h>
> #include <linux/mtd/physmap.h>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
> #include <linux/platform_data/gpio-omap.h>
> #include <linux/platform_data/omap1_bl.h>
>
> diff --git a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c
> index 262ab07447483a..6cac7da15e2b0d 100644
> --- a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c
> +++ b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c
> @@ -17,7 +17,7 @@
> #include <linux/cpufreq.h>
> #include <linux/gpio.h>
>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
>
> #include <plat/cpu-freq.h>
> #include <mach/gpio-samsung.h>
> diff --git a/arch/arm/mach-s3c24xx/mach-osiris.c b/arch/arm/mach-s3c24xx/mach-osiris.c
> index 70b0eb7d31347f..64b1a0b7b803a1 100644
> --- a/arch/arm/mach-s3c24xx/mach-osiris.c
> +++ b/arch/arm/mach-s3c24xx/mach-osiris.c
> @@ -24,7 +24,7 @@
> #include <linux/io.h>
> #include <linux/platform_device.h>
>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
>
> #include <asm/mach-types.h>
> #include <asm/mach/arch.h>
> diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c
> index d829a6131f09e5..2ab67386b4ef1e 100644
> --- a/drivers/mfd/tps65010.c
> +++ b/drivers/mfd/tps65010.c
> @@ -32,7 +32,7 @@
> #include <linux/mutex.h>
> #include <linux/platform_device.h>
>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
>
> #include <linux/gpio/driver.h>
>
> diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
> index a4d814b7f38066..91393ec7d8503c 100644
> --- a/drivers/usb/host/ohci-omap.c
> +++ b/drivers/usb/host/ohci-omap.c
> @@ -53,7 +53,7 @@
> #define DRIVER_DESC "OHCI OMAP driver"
>
> #ifdef CONFIG_TPS65010
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
> #else
>
> #define LOW 0
> diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c
> index 042c5a8fd423d8..c6052c814bcc24 100644
> --- a/drivers/usb/phy/phy-isp1301-omap.c
> +++ b/drivers/usb/phy/phy-isp1301-omap.c
> @@ -96,7 +96,7 @@ struct isp1301 {
>
> #if IS_REACHABLE(CONFIG_TPS65010)
>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
>
> #else
>
> diff --git a/drivers/video/fbdev/omap/lcd_h3.c b/drivers/video/fbdev/omap/lcd_h3.c
> index 9d2da146813ef0..796f4634c4c6f1 100644
> --- a/drivers/video/fbdev/omap/lcd_h3.c
> +++ b/drivers/video/fbdev/omap/lcd_h3.c
> @@ -21,7 +21,7 @@
>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/i2c/tps65010.h>
> +#include <linux/mfd/tps65010.h>
> #include <linux/gpio.h>
>
> #include "omapfb.h"
> diff --git a/include/linux/i2c/tps65010.h b/include/linux/mfd/tps65010.h
> similarity index 99%
> rename from include/linux/i2c/tps65010.h
> rename to include/linux/mfd/tps65010.h
> index 08aa92278d71cd..a1fb9bc5311de4 100644
> --- a/include/linux/i2c/tps65010.h
> +++ b/include/linux/mfd/tps65010.h
> @@ -1,4 +1,4 @@
> -/* linux/i2c/tps65010.h
> +/* linux/mfd/tps65010.h
> *
> * Functions to access TPS65010 power management device.
> *
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-05-23 7:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 22:02 [PATCH 0/3] mfd: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 22:02 ` [PATCH 1/3] mfd: dm355evm_msp: move header file out of I2C realm Wolfram Sang
2017-05-22 9:14 ` Alexandre Belloni
2017-05-22 23:36 ` Dmitry Torokhov
2017-05-23 7:17 ` Lee Jones
2017-08-13 13:34 ` Wolfram Sang
2017-08-14 6:43 ` Lee Jones
2017-08-14 8:25 ` Wolfram Sang
2017-05-21 22:02 ` [PATCH 2/3] mfd: tps65010: " Wolfram Sang
2017-05-22 7:24 ` Greg Kroah-Hartman
2017-05-22 7:34 ` Krzysztof Kozlowski
2017-05-23 7:18 ` Lee Jones [this message]
2017-08-13 13:34 ` Wolfram Sang
2017-08-14 6:43 ` Lee Jones
2017-08-14 8:44 ` Lee Jones
2017-08-14 16:21 ` Tony Lindgren
2017-08-14 16:29 ` Wolfram Sang
2017-05-29 9:19 ` Bartlomiej Zolnierkiewicz
2017-05-21 22:02 ` [PATCH 3/3] mfd: twl: " Wolfram Sang
2017-05-22 7:25 ` Greg Kroah-Hartman
2017-05-22 9:14 ` Alexandre Belloni
2017-05-22 9:52 ` Mark Brown
2017-05-22 10:28 ` Wolfram Sang
2017-05-22 11:12 ` Mark Brown
2017-05-22 10:27 ` Sebastian Reichel
2017-05-22 20:34 ` Jonathan Cameron
2017-05-22 23:37 ` Dmitry Torokhov
2017-05-23 7:16 ` Lee Jones
2017-05-23 7:21 ` Wolfram Sang
2017-05-23 7:42 ` Kishon Vijay Abraham I
2017-05-29 9:20 ` Bartlomiej Zolnierkiewicz
2017-07-06 6:44 ` Thierry Reding
2017-07-06 7:03 ` Lee Jones
2017-08-13 13:37 ` Wolfram Sang
2017-08-14 6:42 ` Lee Jones
2017-08-14 8:43 ` Wolfram Sang
2017-08-14 16:22 ` Tony Lindgren
2017-08-14 16:27 ` Daniel Thompson
2017-08-14 16:32 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523071819.4zpdef7ofzz3moil@dell \
--to=lee.jones@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=stern@rowland.harvard.edu \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).