From: Lee Jones <lee.jones@linaro.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com,
robh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/18] dt-bindings: mfd: Add bindings for Cirrus Logic Madera codecs
Date: Mon, 22 May 2017 18:40:53 +0100 [thread overview]
Message-ID: <20170522174053.kdwralsl4pivhkrq@dell> (raw)
In-Reply-To: <1493050124-5970-4-git-send-email-rf@opensource.wolfsonmicro.com>
On Mon, 24 Apr 2017, Richard Fitzgerald wrote:
> Specification of the bindings for the parent MFD driver component
> of the Cirrus Logic Madera codec drivers.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
> Changes since V1:
> - split out from main MFD patch
> - moved interrupt control binding descriptions into here
> - added description of the regulator child nodes
> - fixed the node name of the example
> - removed the MICBIAS from the example, these have been removed from the code
>
> Documentation/devicetree/bindings/mfd/madera.txt | 96 ++++++++++++++++++++++++
> 1 file changed, 96 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/madera.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/madera.txt b/Documentation/devicetree/bindings/mfd/madera.txt
> new file mode 100644
> index 0000000..af9b85f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/madera.txt
> @@ -0,0 +1,96 @@
> +Cirrus Logic Madera class audio codecs multi-function device
Nit: Multi-Functional Device
Other than that:
Acked-by: Lee Jones <lee.jones@linaro.org>
> +These devices are audio SoCs with extensive digital capabilities and a range
> +of analogue I/O.
> +
> +See also the child driver bindings in:
> +bindings/gpio/gpio-madera.txt
> +bindings/pinctrl/cirrus,madera-pinctrl.txt
> +bindings/regulator/arizona-regulator.txt
> +bindings/sound/madera.txt
> +
> +Required properties:
> +
> + - compatible : One of the following chip-specific strings:
> + "cirrus,cs47l35"
> + "cirrus,cs47l85"
> + "cirrus,cs47l90"
> + "cirrus,cs47l91"
> + "cirrus,wm1840"
> +
> + - reg : I2C slave address when connected using I2C, chip select number when
> + using SPI.
> +
> + - DCVDD-supply : Power supply for the device as defined in
> + bindings/regulator/regulator.txt
> + Mandatory on CS47L35, CS47L90, CS47L91
> + Optional on CS47L85, WM1840
> +
> + - AVDD-supply, DBVDD1-supply, DBVDD2-supply, CPVDD1-supply, CPVDD2-supply :
> + Power supplies for the device
> +
> + - DBVDD3-supply, DBVDD4-supply : Power supplies for the device
> + (CS47L85, CS47L90, CS47L91, WM1840)
> +
> + - SPKVDDL-supply, SPKVDDR-supply : Power supplies for the device
> + (CS47L85, WM1840)
> +
> + - SPKVDD-supply : Power supply for the device
> + (CS47L35)
> +
> + - interrupt-controller : Madera class devices contain interrupt controllers
> + and may provide interrupt services to other devices.
> +
> + - #interrupt-cells: the number of cells to describe an IRQ, must be 2.
> + The first cell is the IRQ number.
> + The second cell is the flags, encoded as the trigger masks from
> + bindings/interrupt-controller/interrupts.txt
> +
> + - interrupt-parent : The parent interrupt controller.
> +
> + - interrupts : The interrupt line the /IRQ signal for the device is
> + connected to.
> +
> +Optional properties:
> +
> + - MICVDD-supply : Power supply, only need to be specified if
> + powered externally
> +
> + - reset-gpios : One entry specifying the GPIO controlling /RESET.
> + As defined in bindings/gpio.txt.
> + Although optional, it is strongly recommended to use a hardware reset
> +
> + - MICBIASx : Initial data for the MICBIAS regulators, as covered in
> + Documentation/devicetree/bindings/regulator/regulator.txt.
> + One for each MICBIAS generator (MICBIAS1, MICBIAS2, ...)
> + (all codecs)
> +
> + One for each output pin (MICBIAS1A, MIBCIAS1B, MICBIAS2A, ...)
> + (all except CS47L85, WM1840)
> +
> + The following following additional property is supported for the generator
> + nodes:
> + - cirrus,ext-cap : Set to 1 if the MICBIAS has external decoupling
> + capacitors attached.
> +
> +Optional child nodes:
> + micvdd : Node containing initialization data for the micvdd regulator
> + See bindings/regulator/arizona-regulator.txt
> +
> + ldo1 : Node containing initialization data for the LDO1 regulator
> + See bindings/regulator/arizona-regulator.txt
> + (cs47l85, wm1840)
> +
> +Example:
> +
> +cs47l85@0 {
> + compatible = "cirrus,cs47l85";
> + reg = <0>;
> +
> + reset-gpios = <&gpio 0>;
> +
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = <&host_irq1>;
> + interrupt-parent = <&gic>;
> +};
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-05-22 17:41 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 16:08 [PATCH v2 00/18] Add support for Cirrus Logic CS47L35/L85/L90/L91 codecs Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 01/18] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Richard Fitzgerald
2017-05-23 7:20 ` Lee Jones
2017-07-13 8:02 ` Lee Jones
2017-07-13 10:05 ` Mark Brown
2017-07-13 12:44 ` Richard Fitzgerald
2017-07-13 13:03 ` Mark Brown
2017-07-14 11:50 ` Richard Fitzgerald
2017-07-14 12:06 ` [alsa-devel] " Takashi Iwai
2017-04-24 16:08 ` [PATCH v2 02/18] mfd: madera: Add common support " Richard Fitzgerald
2017-05-22 17:39 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 03/18] dt-bindings: mfd: Add bindings " Richard Fitzgerald
2017-04-28 18:07 ` Rob Herring
2017-05-22 17:40 ` Lee Jones [this message]
2017-04-24 16:08 ` [PATCH v2 04/18] mfd: madera: Register map tables for Cirrus Logic CS47L35 Richard Fitzgerald
2017-05-23 7:22 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 05/18] mfd: madera: Register map tables for Cirrus Logic CS47L85 Richard Fitzgerald
2017-05-23 7:23 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 06/18] mfd: madera: Register map tables for Cirrus Logic CS47L90/91 Richard Fitzgerald
2017-05-23 7:24 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 07/18] regulator: arizona-micsupp: Add support for Cirrus Logic Madera codecs Richard Fitzgerald
2017-04-28 18:07 ` Rob Herring
2017-04-24 16:08 ` [PATCH v2 08/18] regulator: arizona-ldo1: " Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 09/18] irqchip: Add driver " Richard Fitzgerald
2017-05-10 15:03 ` Thomas Gleixner
2017-04-24 16:08 ` [PATCH v2 10/18] pinctrl: madera: " Richard Fitzgerald
2017-04-25 9:41 ` Linus Walleij
2017-04-25 10:26 ` Richard Fitzgerald
2017-04-28 7:39 ` Linus Walleij
2017-05-20 20:06 ` Paul Gortmaker
2017-04-24 16:08 ` [PATCH v2 11/18] dt-bindings: pinctrl: Add bindings " Richard Fitzgerald
2017-04-25 9:35 ` Linus Walleij
2017-04-28 18:16 ` Rob Herring
2017-04-24 16:08 ` [PATCH v2 12/18] gpio: madera: Support Cirrus Logic Madera class codecs Richard Fitzgerald
2017-04-25 14:13 ` Linus Walleij
2017-04-25 14:44 ` Richard Fitzgerald
2017-04-28 7:46 ` Linus Walleij
2017-04-28 7:44 ` Linus Walleij
2017-04-24 16:08 ` [PATCH v2 13/18] dt-bindings: gpio: Add bindings for GPIO on Cirrus Logic Madera codecs Richard Fitzgerald
2017-04-25 9:42 ` Linus Walleij
2017-04-28 18:17 ` Rob Herring
2017-04-24 16:08 ` [PATCH v2 14/18] ASoC: madera: Add common support for " Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 15/18] dt-bindings: sound: Add bindings " Richard Fitzgerald
2017-04-25 15:52 ` Mark Brown
2017-04-25 16:27 ` Richard Fitzgerald
2017-05-14 10:04 ` Mark Brown
2017-04-28 18:06 ` Rob Herring
2017-04-24 16:08 ` [PATCH v2 16/18] ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 17/18] ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 18/18] ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522174053.kdwralsl4pivhkrq@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).