From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>, <linus.walleij@linaro.org>,
<gnurou@gmail.com>, <robh+dt@kernel.org>, <tglx@linutronix.de>,
<jason@lakedaemon.net>, <alsa-devel@alsa-project.org>,
<patches@opensource.wolfsonmicro.com>,
<linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 01/18] mfd: madera: Add register definitions for Cirrus Logic Madera codecs
Date: Thu, 13 Jul 2017 13:44:10 +0100 [thread overview]
Message-ID: <1499949850.4826.88.camel@rf-debian.wolfsonmicro.main> (raw)
In-Reply-To: <20170713100539.mqvyxgvwqowjim6i@sirena.org.uk>
On Thu, 2017-07-13 at 11:05 +0100, Mark Brown wrote:
> On Thu, Jul 13, 2017 at 09:02:10AM +0100, Lee Jones wrote:
>
> > This patch has been rejected by Linus.
>
> > https://lkml.org/lkml/2017/7/7/579
>
> Hrm, when I used to push the register definition patches I did elide all
> the obviously repeated register banks like the write sequencer one that
> Linus is calling out there. I'm surprised by the "every single line"
> bit though...
Linux doesn't say what he wants us to do about it. I could manually
strip out a few more definitions but seriously, it makes the code a lot
harder to maintain if we can't grep it for use of registers and register
fields. They are big chips, they have a lot of stuff in the registers.
next prev parent reply other threads:[~2017-07-13 12:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 16:08 [PATCH v2 00/18] Add support for Cirrus Logic CS47L35/L85/L90/L91 codecs Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 01/18] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Richard Fitzgerald
2017-05-23 7:20 ` Lee Jones
2017-07-13 8:02 ` Lee Jones
2017-07-13 10:05 ` Mark Brown
2017-07-13 12:44 ` Richard Fitzgerald [this message]
2017-07-13 13:03 ` Mark Brown
2017-07-14 11:50 ` Richard Fitzgerald
2017-07-14 12:06 ` [alsa-devel] " Takashi Iwai
2017-04-24 16:08 ` [PATCH v2 02/18] mfd: madera: Add common support " Richard Fitzgerald
2017-05-22 17:39 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 03/18] dt-bindings: mfd: Add bindings " Richard Fitzgerald
2017-04-28 18:07 ` Rob Herring
2017-05-22 17:40 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 04/18] mfd: madera: Register map tables for Cirrus Logic CS47L35 Richard Fitzgerald
2017-05-23 7:22 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 05/18] mfd: madera: Register map tables for Cirrus Logic CS47L85 Richard Fitzgerald
2017-05-23 7:23 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 06/18] mfd: madera: Register map tables for Cirrus Logic CS47L90/91 Richard Fitzgerald
2017-05-23 7:24 ` Lee Jones
2017-04-24 16:08 ` [PATCH v2 07/18] regulator: arizona-micsupp: Add support for Cirrus Logic Madera codecs Richard Fitzgerald
2017-04-28 18:07 ` Rob Herring
2017-04-24 16:08 ` [PATCH v2 08/18] regulator: arizona-ldo1: " Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 09/18] irqchip: Add driver " Richard Fitzgerald
2017-05-10 15:03 ` Thomas Gleixner
2017-04-24 16:08 ` [PATCH v2 10/18] pinctrl: madera: " Richard Fitzgerald
2017-04-25 9:41 ` Linus Walleij
2017-04-25 10:26 ` Richard Fitzgerald
2017-04-28 7:39 ` Linus Walleij
2017-05-20 20:06 ` Paul Gortmaker
2017-04-24 16:08 ` [PATCH v2 11/18] dt-bindings: pinctrl: Add bindings " Richard Fitzgerald
2017-04-25 9:35 ` Linus Walleij
2017-04-28 18:16 ` Rob Herring
2017-04-24 16:08 ` [PATCH v2 12/18] gpio: madera: Support Cirrus Logic Madera class codecs Richard Fitzgerald
2017-04-25 14:13 ` Linus Walleij
2017-04-25 14:44 ` Richard Fitzgerald
2017-04-28 7:46 ` Linus Walleij
2017-04-28 7:44 ` Linus Walleij
2017-04-24 16:08 ` [PATCH v2 13/18] dt-bindings: gpio: Add bindings for GPIO on Cirrus Logic Madera codecs Richard Fitzgerald
2017-04-25 9:42 ` Linus Walleij
2017-04-28 18:17 ` Rob Herring
2017-04-24 16:08 ` [PATCH v2 14/18] ASoC: madera: Add common support for " Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 15/18] dt-bindings: sound: Add bindings " Richard Fitzgerald
2017-04-25 15:52 ` Mark Brown
2017-04-25 16:27 ` Richard Fitzgerald
2017-05-14 10:04 ` Mark Brown
2017-04-28 18:06 ` Rob Herring
2017-04-24 16:08 ` [PATCH v2 16/18] ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 17/18] ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 Richard Fitzgerald
2017-04-24 16:08 ` [PATCH v2 18/18] ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499949850.4826.88.camel@rf-debian.wolfsonmicro.main \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jason@lakedaemon.net \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).