* [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe
@ 2017-05-22 13:33 Arnd Bergmann
2017-05-22 15:51 ` Ulf Hansson
2017-05-23 5:31 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-05-22 13:33 UTC (permalink / raw)
To: Ulf Hansson, Wolfram Sang, Simon Horman
Cc: Arnd Bergmann, Chris Brandt, linux-mmc, linux-kernel
We now build the sdhi driver in separate modules, which means we
have to export the symbols that are called from another module:
ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mmc/host/renesas_sdhi_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index 846ee1a8e5a6..fa6c188e0327 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
eprobe:
return ret;
}
+EXPORT_SYMBOL_GPL(renesas_sdhi_probe);
int renesas_sdhi_remove(struct platform_device *pdev)
{
@@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev)
return 0;
}
+EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe
2017-05-22 13:33 [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe Arnd Bergmann
@ 2017-05-22 15:51 ` Ulf Hansson
2017-05-23 8:00 ` Wolfram Sang
2017-05-23 5:31 ` Simon Horman
1 sibling, 1 reply; 4+ messages in thread
From: Ulf Hansson @ 2017-05-22 15:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Wolfram Sang, Simon Horman, Chris Brandt, linux-mmc, linux-kernel
On 22 May 2017 at 15:33, Arnd Bergmann <arnd@arndb.de> wrote:
> We now build the sdhi driver in separate modules, which means we
> have to export the symbols that are called from another module:
>
> ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
>
> Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 846ee1a8e5a6..fa6c188e0327 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> eprobe:
> return ret;
> }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_probe);
>
> int renesas_sdhi_remove(struct platform_device *pdev)
> {
> @@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev)
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe
2017-05-22 15:51 ` Ulf Hansson
@ 2017-05-23 8:00 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2017-05-23 8:00 UTC (permalink / raw)
To: Ulf Hansson
Cc: Arnd Bergmann, Wolfram Sang, Simon Horman, Chris Brandt,
linux-mmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Mon, May 22, 2017 at 05:51:57PM +0200, Ulf Hansson wrote:
> On 22 May 2017 at 15:33, Arnd Bergmann <arnd@arndb.de> wrote:
> > We now build the sdhi driver in separate modules, which means we
> > have to export the symbols that are called from another module:
> >
> > ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> > ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> >
> > Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks, applied for next!
Wow, that was fast :) FWIW:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks, Arnd!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe
2017-05-22 13:33 [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe Arnd Bergmann
2017-05-22 15:51 ` Ulf Hansson
@ 2017-05-23 5:31 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2017-05-23 5:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ulf Hansson, Wolfram Sang, Chris Brandt, linux-mmc, linux-kernel
On Mon, May 22, 2017 at 03:33:08PM +0200, Arnd Bergmann wrote:
> We now build the sdhi driver in separate modules, which means we
> have to export the symbols that are called from another module:
>
> ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
>
> Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
Sorry for messing this up and thanks for the fix.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 846ee1a8e5a6..fa6c188e0327 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> eprobe:
> return ret;
> }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_probe);
>
> int renesas_sdhi_remove(struct platform_device *pdev)
> {
> @@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev)
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-23 8:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-22 13:33 [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe Arnd Bergmann
2017-05-22 15:51 ` Ulf Hansson
2017-05-23 8:00 ` Wolfram Sang
2017-05-23 5:31 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).