linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Sanchayan Maity <maitysanchayan@gmail.com>,
	Gregor Boirie <gregor.boirie@parrot.com>,
	Matt Ranostay <mranostay@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chris Healy <Chris.Healy@zii.aero>,
	Jeff White <Jeff.White@zii.aero>,
	Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH] iio: hi8435: remote ampersands from hi8435_info definition
Date: Wed, 24 May 2017 20:28:53 +0100	[thread overview]
Message-ID: <20170524202853.0cfc4c1e@kernel.org> (raw)
In-Reply-To: <20170523080746.20512-1-nikita.yoush@cogentembedded.com>

On Tue, 23 May 2017 11:07:46 +0300
Nikita Yushchenko <nikita.yoush@cogentembedded.com> wrote:

> C syntax allows apersands when initializing structures fields with
> function pointers, but in Linux sources ampersands are normally not used
> in thix context.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,
Jonathan
> ---
>  drivers/iio/adc/hi8435.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
> index 28fc699f00f6..ef5c286c8e67 100644
> --- a/drivers/iio/adc/hi8435.c
> +++ b/drivers/iio/adc/hi8435.c
> @@ -414,11 +414,11 @@ static const struct iio_chan_spec hi8435_channels[] = {
>  static const struct iio_info hi8435_info = {
>  	.driver_module = THIS_MODULE,
>  	.read_raw = hi8435_read_raw,
> -	.read_event_config = &hi8435_read_event_config,
> +	.read_event_config = hi8435_read_event_config,
>  	.write_event_config = hi8435_write_event_config,
> -	.read_event_value = &hi8435_read_event_value,
> -	.write_event_value = &hi8435_write_event_value,
> -	.debugfs_reg_access = &hi8435_debugfs_reg_access,
> +	.read_event_value = hi8435_read_event_value,
> +	.write_event_value = hi8435_write_event_value,
> +	.debugfs_reg_access = hi8435_debugfs_reg_access,
>  };
>  
>  static void hi8435_iio_push_event(struct iio_dev *idev, unsigned int val)

      reply	other threads:[~2017-05-24 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23  8:07 [PATCH] iio: hi8435: remote ampersands from hi8435_info definition Nikita Yushchenko
2017-05-24 19:28 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170524202853.0cfc4c1e@kernel.org \
    --to=jic23@kernel.org \
    --cc=Chris.Healy@zii.aero \
    --cc=Jeff.White@zii.aero \
    --cc=gregor.boirie@parrot.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maitysanchayan@gmail.com \
    --cc=mranostay@gmail.com \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=pmeerw@pmeerw.net \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).