* [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable
@ 2017-05-26 6:37 Arvind Yadav
2017-05-28 14:50 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-05-26 6:37 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, soren.brinkmann
Cc: linux-iio, linux-arm-kernel, linux-kernel
clk_prepare_enable() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/iio/adc/xilinx-xadc-core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
index 56cf590..4a60497 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev)
ret = PTR_ERR(xadc->clk);
goto err_free_samplerate_trigger;
}
- clk_prepare_enable(xadc->clk);
+
+ ret = clk_prepare_enable(xadc->clk);
+ if (ret)
+ goto err_free_samplerate_trigger;
ret = xadc->ops->setup(pdev, indio_dev, irq);
if (ret)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable
2017-05-26 6:37 [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable Arvind Yadav
@ 2017-05-28 14:50 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-05-28 14:50 UTC (permalink / raw)
To: Arvind Yadav
Cc: knaack.h, lars, pmeerw, soren.brinkmann, linux-iio,
linux-arm-kernel, linux-kernel
On Fri, 26 May 2017 12:07:41 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Straight forward looking so I've applied this to the togreg
branch of iio.git and pushed it out as testing for the autobuilders
to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 56cf590..4a60497 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev)
> ret = PTR_ERR(xadc->clk);
> goto err_free_samplerate_trigger;
> }
> - clk_prepare_enable(xadc->clk);
> +
> + ret = clk_prepare_enable(xadc->clk);
> + if (ret)
> + goto err_free_samplerate_trigger;
>
> ret = xadc->ops->setup(pdev, indio_dev, irq);
> if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-28 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-26 6:37 [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable Arvind Yadav
2017-05-28 14:50 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).