* [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?)
@ 2017-05-28 18:06 Chen Guanqiao
2017-05-28 19:58 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Chen Guanqiao @ 2017-05-28 18:06 UTC (permalink / raw)
To: mchehab, linux-media, devel
Cc: gregkh, alan, fengguang.wu, linux-kernel, Chen Guanqiao
Fix "symbol 'xxxxxxx' was not declared. Should it be static?" sparse warnings.
Signed-off-by: Chen Guanqiao <chen.chenchacha@foxmail.com>
---
drivers/staging/media/atomisp/i2c/lm3554.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/lm3554.c b/drivers/staging/media/atomisp/i2c/lm3554.c
index dd9c9c3ffff7..2b170c07aaba 100644
--- a/drivers/staging/media/atomisp/i2c/lm3554.c
+++ b/drivers/staging/media/atomisp/i2c/lm3554.c
@@ -497,7 +497,7 @@ static const struct v4l2_ctrl_ops ctrl_ops = {
.g_volatile_ctrl = lm3554_g_volatile_ctrl
};
-struct v4l2_ctrl_config lm3554_controls[] = {
+static const struct v4l2_ctrl_config lm3554_controls[] = {
{
.ops = &ctrl_ops,
.id = V4L2_CID_FLASH_TIMEOUT,
@@ -825,7 +825,7 @@ static int lm3554_gpio_uninit(struct i2c_client *client)
return 0;
}
-void *lm3554_platform_data_func(struct i2c_client *client)
+static void *lm3554_platform_data_func(struct i2c_client *client)
{
static struct lm3554_platform_data platform_data;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?)
2017-05-28 18:06 [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?) Chen Guanqiao
@ 2017-05-28 19:58 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2017-05-28 19:58 UTC (permalink / raw)
To: Chen Guanqiao
Cc: mchehab, linux-media, devel, gregkh, alan, fengguang.wu, linux-kernel
On Mon, 29 May 2017 02:06:41 +0800
Chen Guanqiao <chen.chenchacha@foxmail.com> wrote:
> Fix "symbol 'xxxxxxx' was not declared. Should it be static?" sparse warnings.
>
> Signed-off-by: Chen Guanqiao <chen.chenchacha@foxmail.com>
> ---
Reviewed-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-28 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-28 18:06 [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?) Chen Guanqiao
2017-05-28 19:58 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).