linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Vince Weaver <vince@deater.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>
Subject: Re: perf group read for inherited events
Date: Tue, 30 May 2017 06:57:14 -0700	[thread overview]
Message-ID: <20170530135714.GJ24144@tassilo.jf.intel.com> (raw)
In-Reply-To: <20170530094512.dy2nljns2uq7qa3j@hirez.programming.kicks-ass.net>

On Tue, May 30, 2017 at 11:45:12AM +0200, Peter Zijlstra wrote:
> > Or is the simple patch below good enough?
> 
> The below seems to be the correct thing. It is rather unfortunate that
> this would break/significantly change existing semantics :/

The "existing semantics" as in ignoring the PERF_SAMPLE_READ in sample_type,
even though it wasn't implemented? It seems reasonable to me.

If you really worry about it could drop a printk_once in and see if it
triggers anywhere (and if yes drop the if completely)

The patch looks good to me. Please consider adding it.
I have some patches to use this in perf stat, will submit later.

-Andi

  reply	other threads:[~2017-05-30 13:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170526205601.GA5271@tassilo.jf.intel.com>
2017-05-30  9:45 ` perf group read for inherited events Peter Zijlstra
2017-05-30 13:57   ` Andi Kleen [this message]
2017-05-30 17:01     ` Peter Zijlstra
2017-05-30 17:55       ` Vince Weaver
2017-05-30 18:53         ` Peter Zijlstra
2017-05-31 21:08           ` Vince Weaver
2017-06-08  9:21   ` [tip:perf/core] perf/core: Correct event creation with PERF_FORMAT_GROUP tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530135714.GJ24144@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vince@deater.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).