From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Vince Weaver <vince@deater.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Stephane Eranian <eranian@google.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: perf group read for inherited events
Date: Tue, 30 May 2017 19:01:50 +0200 [thread overview]
Message-ID: <20170530170150.cx554x7nmbrzv7nc@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170530135714.GJ24144@tassilo.jf.intel.com>
On Tue, May 30, 2017 at 06:57:14AM -0700, Andi Kleen wrote:
> On Tue, May 30, 2017 at 11:45:12AM +0200, Peter Zijlstra wrote:
> > > Or is the simple patch below good enough?
> >
> > The below seems to be the correct thing. It is rather unfortunate that
> > this would break/significantly change existing semantics :/
>
> The "existing semantics" as in ignoring the PERF_SAMPLE_READ in sample_type,
> even though it wasn't implemented? It seems reasonable to me.
Right, so where we used to accept PERF_SAMPLE_READ on inherited events,
we now no longer will.
Note that it currently doesn't work right, even if it doesn't fail like
with the proposed patch.
Typically Vince will (rightly) complain when I change things like this.
But seeing how even if we accept it, it is fairly terminally buggered in
any case, we could change it.
Vince, do you know of anybody that would be immediately affected by
this?
next prev parent reply other threads:[~2017-05-30 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170526205601.GA5271@tassilo.jf.intel.com>
2017-05-30 9:45 ` perf group read for inherited events Peter Zijlstra
2017-05-30 13:57 ` Andi Kleen
2017-05-30 17:01 ` Peter Zijlstra [this message]
2017-05-30 17:55 ` Vince Weaver
2017-05-30 18:53 ` Peter Zijlstra
2017-05-31 21:08 ` Vince Weaver
2017-06-08 9:21 ` [tip:perf/core] perf/core: Correct event creation with PERF_FORMAT_GROUP tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530170150.cx554x7nmbrzv7nc@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).