From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH] perf test: Disable breakpoint signal tests for powerpc
Date: Thu, 1 Jun 2017 15:10:07 +0200 [thread overview]
Message-ID: <20170601131007.GA27070@krava> (raw)
In-Reply-To: <20170601130458.GB2899@kernel.org>
On Thu, Jun 01, 2017 at 10:04:58AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 16, 2017 at 07:49:42PM +0200, Jiri Olsa escreveu:
> > Following tests are constantly failing on powerpc:
> >
> > # perf test break
> > 18: Breakpoint overflow signal handler : FAILED!
> > 19: Breakpoint overflow sampling : FAILED!
> >
> > The powerpc so far does not have support to even create
> > instruction breakpoint using the perf event interface,
> > so those tests fail early in the config phase.
> >
> > I added 'ison' callback to test struct to be able to
> > disable specific test. It seems better than putting
> > ifdefs directly to the test array.
> >
> > Link: http://lkml.kernel.org/n/tip-erwshbq6f7b7hdtu65z5a25y@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> > tools/perf/tests/bp_signal.c | 14 ++++++++++++++
> > tools/perf/tests/builtin-test.c | 7 +++++++
> > tools/perf/tests/tests.h | 3 +++
> > 3 files changed, 24 insertions(+)
> >
> > diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c
> > index e7664fe3bd33..0467c3b6d849 100644
> > --- a/tools/perf/tests/bp_signal.c
> > +++ b/tools/perf/tests/bp_signal.c
> > @@ -288,3 +288,17 @@ int test__bp_signal(int subtest __maybe_unused)
> > return count1 == 1 && overflows == 3 && count2 == 3 && overflows_2 == 3 && count3 == 2 ?
> > TEST_OK : TEST_FAIL;
> > }
> > +
> > +bool test__bp_signal_is_on(void)
>
> Can you please rename this "_is_on()" thing to "_supported()"?
ok
jirka
next prev parent reply other threads:[~2017-06-01 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 17:49 [PATCH] perf test: Disable breakpoint signal tests for powerpc Jiri Olsa
2017-06-01 13:04 ` Arnaldo Carvalho de Melo
2017-06-01 13:10 ` Jiri Olsa [this message]
2017-06-01 20:54 ` [PATCHv2] " Jiri Olsa
2017-06-02 14:04 ` Arnaldo Carvalho de Melo
2017-06-02 14:05 ` Arnaldo Carvalho de Melo
2017-06-02 14:31 ` Arnaldo Carvalho de Melo
2017-06-04 18:54 ` Jiri Olsa
2017-06-07 15:59 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601131007.GA27070@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).