* [PATCH] hexagon: Use raw_copy_to_user
@ 2017-05-03 3:52 Guenter Roeck
2017-05-03 5:17 ` Al Viro
2017-06-02 13:03 ` Guenter Roeck
0 siblings, 2 replies; 5+ messages in thread
From: Guenter Roeck @ 2017-05-03 3:52 UTC (permalink / raw)
To: Richard Kuo; +Cc: linux-hexagon, linux-kernel, Guenter Roeck, Al Viro
Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
__copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
all callers, resulting in the following build error.
arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
arch/hexagon/mm/uaccess.c:40:3: error:
implicit declaration of function '__copy_to_user_hexagon'
Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/hexagon/mm/uaccess.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
index ec90afdb3ad0..c599eb126c9e 100644
--- a/arch/hexagon/mm/uaccess.c
+++ b/arch/hexagon/mm/uaccess.c
@@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
long uncleared;
while (count > PAGE_SIZE) {
- uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
- PAGE_SIZE);
+ uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
if (uncleared)
return count - (PAGE_SIZE - uncleared);
count -= PAGE_SIZE;
dest += PAGE_SIZE;
}
if (count)
- count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
+ count = raw_copy_to_user(dest, &empty_zero_page, count);
return count;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] hexagon: Use raw_copy_to_user
2017-05-03 3:52 [PATCH] hexagon: Use raw_copy_to_user Guenter Roeck
@ 2017-05-03 5:17 ` Al Viro
2017-06-02 13:03 ` Guenter Roeck
1 sibling, 0 replies; 5+ messages in thread
From: Al Viro @ 2017-05-03 5:17 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Richard Kuo, linux-hexagon, linux-kernel
On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> all callers, resulting in the following build error.
>
> arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> arch/hexagon/mm/uaccess.c:40:3: error:
> implicit declaration of function '__copy_to_user_hexagon'
>
> Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: hexagon: Use raw_copy_to_user
2017-05-03 3:52 [PATCH] hexagon: Use raw_copy_to_user Guenter Roeck
2017-05-03 5:17 ` Al Viro
@ 2017-06-02 13:03 ` Guenter Roeck
2017-06-02 21:33 ` Richard Kuo
1 sibling, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2017-06-02 13:03 UTC (permalink / raw)
To: Richard Kuo; +Cc: linux-hexagon, linux-kernel, Al Viro
ping ....
On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> all callers, resulting in the following build error.
>
> arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> arch/hexagon/mm/uaccess.c:40:3: error:
> implicit declaration of function '__copy_to_user_hexagon'
>
> Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> arch/hexagon/mm/uaccess.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> index ec90afdb3ad0..c599eb126c9e 100644
> --- a/arch/hexagon/mm/uaccess.c
> +++ b/arch/hexagon/mm/uaccess.c
> @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
> long uncleared;
>
> while (count > PAGE_SIZE) {
> - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> - PAGE_SIZE);
> + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
> if (uncleared)
> return count - (PAGE_SIZE - uncleared);
> count -= PAGE_SIZE;
> dest += PAGE_SIZE;
> }
> if (count)
> - count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> + count = raw_copy_to_user(dest, &empty_zero_page, count);
>
> return count;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: hexagon: Use raw_copy_to_user
2017-06-02 13:03 ` Guenter Roeck
@ 2017-06-02 21:33 ` Richard Kuo
2017-06-02 22:45 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Richard Kuo @ 2017-06-02 21:33 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-hexagon, linux-kernel, Al Viro
On Fri, Jun 02, 2017 at 06:03:53AM -0700, Guenter Roeck wrote:
> ping ....
>
> On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> > Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> > __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> > all callers, resulting in the following build error.
> >
> > arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> > arch/hexagon/mm/uaccess.c:40:3: error:
> > implicit declaration of function '__copy_to_user_hexagon'
> >
> > Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> > ---
> > arch/hexagon/mm/uaccess.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> > index ec90afdb3ad0..c599eb126c9e 100644
> > --- a/arch/hexagon/mm/uaccess.c
> > +++ b/arch/hexagon/mm/uaccess.c
> > @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
> > long uncleared;
> >
> > while (count > PAGE_SIZE) {
> > - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> > - PAGE_SIZE);
> > + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
> > if (uncleared)
> > return count - (PAGE_SIZE - uncleared);
> > count -= PAGE_SIZE;
> > dest += PAGE_SIZE;
> > }
> > if (count)
> > - count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> > + count = raw_copy_to_user(dest, &empty_zero_page, count);
> >
> > return count;
> > }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Richard Kuo <rkuo@codeaurora.org>
Thanks!
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: hexagon: Use raw_copy_to_user
2017-06-02 21:33 ` Richard Kuo
@ 2017-06-02 22:45 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2017-06-02 22:45 UTC (permalink / raw)
To: Richard Kuo; +Cc: linux-hexagon, linux-kernel, Al Viro
Hi Richard,
On Fri, Jun 02, 2017 at 04:33:04PM -0500, Richard Kuo wrote:
> On Fri, Jun 02, 2017 at 06:03:53AM -0700, Guenter Roeck wrote:
> > ping ....
> >
> > On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> > > Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> > > __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> > > all callers, resulting in the following build error.
> > >
> > > arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> > > arch/hexagon/mm/uaccess.c:40:3: error:
> > > implicit declaration of function '__copy_to_user_hexagon'
> > >
> > > Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> > > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> > > ---
> > > arch/hexagon/mm/uaccess.c | 5 ++---
> > > 1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> > > index ec90afdb3ad0..c599eb126c9e 100644
> > > --- a/arch/hexagon/mm/uaccess.c
> > > +++ b/arch/hexagon/mm/uaccess.c
> > > @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
> > > long uncleared;
> > >
> > > while (count > PAGE_SIZE) {
> > > - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> > > - PAGE_SIZE);
> > > + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
> > > if (uncleared)
> > > return count - (PAGE_SIZE - uncleared);
> > > count -= PAGE_SIZE;
> > > dest += PAGE_SIZE;
> > > }
> > > if (count)
> > > - count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> > > + count = raw_copy_to_user(dest, &empty_zero_page, count);
> > >
> > > return count;
> > > }
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Acked-by: Richard Kuo <rkuo@codeaurora.org>
>
Do you want me to send it to Linus ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-02 22:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 3:52 [PATCH] hexagon: Use raw_copy_to_user Guenter Roeck
2017-05-03 5:17 ` Al Viro
2017-06-02 13:03 ` Guenter Roeck
2017-06-02 21:33 ` Richard Kuo
2017-06-02 22:45 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).