linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: humidity: hdc100x: document compatible HDC10xx devices
@ 2017-06-02 15:09 Michael Stecklein
  2017-06-03  8:25 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Stecklein @ 2017-06-02 15:09 UTC (permalink / raw)
  To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler
  Cc: linux-iio, linux-kernel, Andrew F . Davis, Michael Stecklein

Include datasheet links to compatible HDC10xx devices.

Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
---

Tested on the HDC1080 but not the HDC1010 and HDC1050, however
their datasheets describe identical functionality.

 drivers/iio/humidity/hdc100x.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
index aa17115..ef17613 100644
--- a/drivers/iio/humidity/hdc100x.c
+++ b/drivers/iio/humidity/hdc100x.c
@@ -13,6 +13,12 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  *
+ * Datasheets:
+ * http://www.ti.com/product/HDC1000/datasheet
+ * http://www.ti.com/product/HDC1008/datasheet
+ * http://www.ti.com/product/HDC1010/datasheet
+ * http://www.ti.com/product/HDC1050/datasheet
+ * http://www.ti.com/product/HDC1080/datasheet
  */
 
 #include <linux/delay.h>
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: humidity: hdc100x: document compatible HDC10xx devices
  2017-06-02 15:09 [PATCH] iio: humidity: hdc100x: document compatible HDC10xx devices Michael Stecklein
@ 2017-06-03  8:25 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-06-03  8:25 UTC (permalink / raw)
  To: Michael Stecklein
  Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
	linux-iio, linux-kernel, Andrew F . Davis, Matt Ranostay

On Fri, 2 Jun 2017 10:09:21 -0500
Michael Stecklein <m-stecklein@ti.com> wrote:

> Include datasheet links to compatible HDC10xx devices.
> 
> Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
Hi Michael,

Would you mind also adding the i2c_device_id entries for these
other parts and updating the kconfig help to mention that they
are supported?  Hmm. Matt, the driver should really have listed
all the parts explicitly in the first place. I was clearly
half asleep whilst reviewing this one.

We'll need to leave the hdc100x entry in there for backwards
compatibility but please add all the others.

Might also be worth taking this opportunity to do an additional
patch adding devicetree bindings for this driver.

If you don't have time for any or all of the above, feel free
to say so!

Thanks,

Jonathan
> ---
> 
> Tested on the HDC1080 but not the HDC1010 and HDC1050, however
> their datasheets describe identical functionality.
> 
>  drivers/iio/humidity/hdc100x.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index aa17115..ef17613 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -13,6 +13,12 @@
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>   * GNU General Public License for more details.
>   *
> + * Datasheets:
> + * http://www.ti.com/product/HDC1000/datasheet
> + * http://www.ti.com/product/HDC1008/datasheet
> + * http://www.ti.com/product/HDC1010/datasheet
> + * http://www.ti.com/product/HDC1050/datasheet
> + * http://www.ti.com/product/HDC1080/datasheet
>   */
>  
>  #include <linux/delay.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-03  8:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-02 15:09 [PATCH] iio: humidity: hdc100x: document compatible HDC10xx devices Michael Stecklein
2017-06-03  8:25 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).