* [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases"
@ 2017-06-08 9:01 Arnd Bergmann
2017-06-08 12:49 ` Sakari Ailus
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-06-08 9:01 UTC (permalink / raw)
To: Pavel Machek, Sakari Ailus, Mauro Carvalho Chehab
Cc: Arnd Bergmann, Javier Martinez Canillas, Ivaylo Dimitrov,
Fengguang Wu, linux-media, linux-kernel
This one got applied twice, causing a build error with clang:
drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition of '__mod_of__et8ek8_of_table_device_table'
Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/i2c/et8ek8/et8ek8_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/et8ek8/et8ek8_driver.c
index 6e313d5243a0..f39f5179dd95 100644
--- a/drivers/media/i2c/et8ek8/et8ek8_driver.c
+++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c
@@ -1496,7 +1496,6 @@ MODULE_DEVICE_TABLE(i2c, et8ek8_id_table);
static const struct dev_pm_ops et8ek8_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(et8ek8_suspend, et8ek8_resume)
};
-MODULE_DEVICE_TABLE(of, et8ek8_of_table);
static struct i2c_driver et8ek8_i2c_driver = {
.driver = {
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases"
2017-06-08 9:01 [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases" Arnd Bergmann
@ 2017-06-08 12:49 ` Sakari Ailus
2017-06-08 16:40 ` Pavel Machek
2017-08-06 23:29 ` Stefan Agner
2 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2017-06-08 12:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Pavel Machek, Mauro Carvalho Chehab, Javier Martinez Canillas,
Ivaylo Dimitrov, Fengguang Wu, linux-media, linux-kernel
On Thu, Jun 08, 2017 at 11:01:37AM +0200, Arnd Bergmann wrote:
> This one got applied twice, causing a build error with clang:
>
> drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition of '__mod_of__et8ek8_of_table_device_table'
>
> Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases"
2017-06-08 9:01 [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases" Arnd Bergmann
2017-06-08 12:49 ` Sakari Ailus
@ 2017-06-08 16:40 ` Pavel Machek
2017-08-06 23:29 ` Stefan Agner
2 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2017-06-08 16:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sakari Ailus, Mauro Carvalho Chehab, Javier Martinez Canillas,
Ivaylo Dimitrov, Fengguang Wu, linux-media, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
On Thu 2017-06-08 11:01:37, Arnd Bergmann wrote:
> This one got applied twice, causing a build error with clang:
>
> drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition of '__mod_of__et8ek8_of_table_device_table'
>
> Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Revert "[media] et8ek8: Export OF device ID as module aliases"
2017-06-08 9:01 [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases" Arnd Bergmann
2017-06-08 12:49 ` Sakari Ailus
2017-06-08 16:40 ` Pavel Machek
@ 2017-08-06 23:29 ` Stefan Agner
2017-08-07 11:09 ` Pavel Machek
2 siblings, 1 reply; 5+ messages in thread
From: Stefan Agner @ 2017-08-06 23:29 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Arnd Bergmann, Pavel Machek, Sakari Ailus,
Javier Martinez Canillas, Ivaylo Dimitrov, Fengguang Wu,
linux-media, linux-kernel
Hi Mauro,
Just hit this issue too. This seems not to have made it into v4.13 as of
today yet, any chance to get it still in?
--
Stefan
On 2017-06-08 02:01, Arnd Bergmann wrote:
> This one got applied twice, causing a build error with clang:
>
> drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition
> of '__mod_of__et8ek8_of_table_device_table'
>
> Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> drivers/media/i2c/et8ek8/et8ek8_driver.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> index 6e313d5243a0..f39f5179dd95 100644
> --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> @@ -1496,7 +1496,6 @@ MODULE_DEVICE_TABLE(i2c, et8ek8_id_table);
> static const struct dev_pm_ops et8ek8_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(et8ek8_suspend, et8ek8_resume)
> };
> -MODULE_DEVICE_TABLE(of, et8ek8_of_table);
>
> static struct i2c_driver et8ek8_i2c_driver = {
> .driver = {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Revert "[media] et8ek8: Export OF device ID as module aliases"
2017-08-06 23:29 ` Stefan Agner
@ 2017-08-07 11:09 ` Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2017-08-07 11:09 UTC (permalink / raw)
To: Stefan Agner
Cc: Mauro Carvalho Chehab, Arnd Bergmann, Sakari Ailus,
Javier Martinez Canillas, Ivaylo Dimitrov, Fengguang Wu,
linux-media, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]
Hi!
> Just hit this issue too. This seems not to have made it into v4.13 as of
> today yet, any chance to get it still in?
If Mauro does not react, I guess we can push the patche through
akpm. Hmm. Or directly to the Linus. -rc really is about fixing
regressions, such as this.
Best regards,
Pavel
> --
> Stefan
>
> On 2017-06-08 02:01, Arnd Bergmann wrote:
> > This one got applied twice, causing a build error with clang:
> >
> > drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition
> > of '__mod_of__et8ek8_of_table_device_table'
> >
> > Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> > ---
> > drivers/media/i2c/et8ek8/et8ek8_driver.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > index 6e313d5243a0..f39f5179dd95 100644
> > --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c
> > @@ -1496,7 +1496,6 @@ MODULE_DEVICE_TABLE(i2c, et8ek8_id_table);
> > static const struct dev_pm_ops et8ek8_pm_ops = {
> > SET_SYSTEM_SLEEP_PM_OPS(et8ek8_suspend, et8ek8_resume)
> > };
> > -MODULE_DEVICE_TABLE(of, et8ek8_of_table);
> >
> > static struct i2c_driver et8ek8_i2c_driver = {
> > .driver = {
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-07 11:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-08 9:01 [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases" Arnd Bergmann
2017-06-08 12:49 ` Sakari Ailus
2017-06-08 16:40 ` Pavel Machek
2017-08-06 23:29 ` Stefan Agner
2017-08-07 11:09 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).