[PATCH] IB/qib: remove duplicate code

[PATCH] IB/qib: remove duplicate code

[Gustavo A. R. Silva]

Remove duplicate code.

Addresses-Coverity-ID: 1226951
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/infiniband/hw/qib/qib_mad.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index da295e0..c5eaa3c 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
 		ib_dispatch_event(&event);
 	}
 
-	ret = subn_get_portinfo(smp, ibdev, port);
-
 	/* restore re-reg bit per o14-12.2.1 */
 	pip->clientrereg_resv_subnetto |= clientrereg;
 
-- 
2.5.0

Re: [PATCH] IB/qib: remove duplicate code

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

On Wed, Jun 07, 2017 at 03:42:02PM -0500, Gustavo A. R. Silva wrote:
> Remove duplicate code.
>
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>  1 file changed, 2 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] IB/qib: remove duplicate code

[Dennis Dalessandro]

On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
> Remove duplicate code.
> 
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>   drivers/infiniband/hw/qib/qib_mad.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
> index da295e0..c5eaa3c 100644
> --- a/drivers/infiniband/hw/qib/qib_mad.c
> +++ b/drivers/infiniband/hw/qib/qib_mad.c
> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
>   		ib_dispatch_event(&event);
>   	}
>   
> -	ret = subn_get_portinfo(smp, ibdev, port);
> -
>   	/* restore re-reg bit per o14-12.2.1 */
>   	pip->clientrereg_resv_subnetto |= clientrereg;
>   
> 

Would be nice to see a few more words in the commit message rather than 
having to go look for Coverity.

Regardless, patch seems fine to me code wise.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

Re: [PATCH] IB/qib: remove duplicate code

[Gustavo A. R. Silva]

Hi Dennis,

Quoting Dennis Dalessandro <dennis.dalessandro@intel.com>:

> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/qib/qib_mad.c  
>> b/drivers/infiniband/hw/qib/qib_mad.c
>> index da295e0..c5eaa3c 100644
>> --- a/drivers/infiniband/hw/qib/qib_mad.c
>> +++ b/drivers/infiniband/hw/qib/qib_mad.c
>> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp  
>> *smp, struct ib_device *ibdev,
>>  		ib_dispatch_event(&event);
>>  	}
>>  -	ret = subn_get_portinfo(smp, ibdev, port);
>> -
>>  	/* restore re-reg bit per o14-12.2.1 */
>>  	pip->clientrereg_resv_subnetto |= clientrereg;
>>
>
> Would be nice to see a few more words in the commit message rather  
> than having to go look for Coverity.
>

I'll take note of that.

> Regardless, patch seems fine to me code wise.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

Thank you
--
Gustavo A. R. Silva

Re: [PATCH] IB/qib: remove duplicate code

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 659 bytes --]

On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
> Remove duplicate code.
> 
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

This patch was accepted into 4.13-rc, thanks.

In addition, I no longer have the original email for another patch of
yours that was also accepted into 4.13-rc.  You created the patch in a
thread asking about the argument position for argument usage in
ib_init_ah_from_wc().  Your comment addition was accepted as well.


-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: [PATCH] IB/qib: remove duplicate code

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 855 bytes --]

On 7/22/2017 1:20 PM, Doug Ledford wrote:
> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> 
> This patch was accepted into 4.13-rc, thanks.

Correction, this patch is in my queue for my for-next branch, only the
other patch, referenced below, made it into 4.13-rc.

> In addition, I no longer have the original email for another patch of
> yours that was also accepted into 4.13-rc.  You created the patch in a
> thread asking about the argument position for argument usage in
> ib_init_ah_from_wc().  Your comment addition was accepted as well.
> 
> 


-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: [PATCH] IB/qib: remove duplicate code

[Gustavo A. R. Silva]

Hi Doug,

On 07/22/2017 12:22 PM, Doug Ledford wrote:
> On 7/22/2017 1:20 PM, Doug Ledford wrote:
>> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>>> Remove duplicate code.
>>>
>>> Addresses-Coverity-ID: 1226951
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>>
>> This patch was accepted into 4.13-rc, thanks.
>
> Correction, this patch is in my queue for my for-next branch, only the
> other patch, referenced below, made it into 4.13-rc.
>

That's cool.

>> In addition, I no longer have the original email for another patch of
>> yours that was also accepted into 4.13-rc.  You created the patch in a
>> thread asking about the argument position for argument usage in
>> ib_init_ah_from_wc().  Your comment addition was accepted as well.
>>
>>

Yeah, I noticed that. I'm glad to help out. :)

Thank you
-- 
Gustavo A. R. Silva