* [PATCH] net: s2io: remove useless variable in fill_rx_buffers
@ 2017-06-15 2:58 Gustavo A. R. Silva
2017-06-15 18:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-15 2:58 UTC (permalink / raw)
To: Jon Mason; +Cc: netdev, linux-kernel, Gustavo A. R. Silva
Remove useless variable rxd_index and code related.
Addresses-Coverity-ID: 1397691
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/net/ethernet/neterion/s2io.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c
index 118723e..fd2ec36 100644
--- a/drivers/net/ethernet/neterion/s2io.c
+++ b/drivers/net/ethernet/neterion/s2io.c
@@ -2459,7 +2459,6 @@ static int fill_rx_buffers(struct s2io_nic *nic, struct ring_info *ring,
struct buffAdd *ba;
struct RxD_t *first_rxdp = NULL;
u64 Buffer0_ptr = 0, Buffer1_ptr = 0;
- int rxd_index = 0;
struct RxD1 *rxdp1;
struct RxD3 *rxdp3;
struct swStat *swstats = &ring->nic->mac_control.stats_info->sw_stat;
@@ -2474,10 +2473,6 @@ static int fill_rx_buffers(struct s2io_nic *nic, struct ring_info *ring,
rxdp = ring->rx_blocks[block_no].rxds[off].virt_addr;
- rxd_index = off + 1;
- if (block_no)
- rxd_index += (block_no * ring->rxd_count);
-
if ((block_no == block_no1) &&
(off == ring->rx_curr_get_info.offset) &&
(rxdp->Host_Control)) {
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: s2io: remove useless variable in fill_rx_buffers
2017-06-15 2:58 [PATCH] net: s2io: remove useless variable in fill_rx_buffers Gustavo A. R. Silva
@ 2017-06-15 18:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-15 18:15 UTC (permalink / raw)
To: garsilva; +Cc: jdmason, netdev, linux-kernel
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Wed, 14 Jun 2017 21:58:17 -0500
> Remove useless variable rxd_index and code related.
>
> Addresses-Coverity-ID: 1397691
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-15 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15 2:58 [PATCH] net: s2io: remove useless variable in fill_rx_buffers Gustavo A. R. Silva
2017-06-15 18:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).