linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning
@ 2017-06-16  9:27 Jaya Durga
  2017-06-16  9:39 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Jaya Durga @ 2017-06-16  9:27 UTC (permalink / raw)
  To: gregkh
  Cc: sergio.paracuellos, adrien.descamps, devel, linux-kernel, Jaya Durga

warning: cast to restricted __le16

Signed-off-by: Jaya Durga <jayad@cdac.in>
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index a812e55..0e95e45 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3380,7 +3380,7 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
	u16 fc;

	/* Byte order convert once up front. */
-	usbin->rxfrm.desc.status = le16_to_cpu(usbin->rxfrm.desc.status);
+	le16_to_cpus(&usbin->rxfrm.desc.status);
	usbin->rxfrm.desc.time = le32_to_cpu(usbin->rxfrm.desc.time);

	/* Now handle frame based on port# */
--
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning
  2017-06-16  9:27 [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning Jaya Durga
@ 2017-06-16  9:39 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-06-16  9:39 UTC (permalink / raw)
  To: Jaya Durga; +Cc: sergio.paracuellos, adrien.descamps, devel, linux-kernel

On Fri, Jun 16, 2017 at 02:57:08PM +0530, Jaya Durga wrote:
> warning: cast to restricted __le16

What does this mean?  It doesn't tell us why you are doing what you are
doing here.

Please be much more specific and descriptive.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-16  9:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-16  9:27 [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning Jaya Durga
2017-06-16  9:39 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).