linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends
Date: Sat, 17 Jun 2017 21:27:04 +0200	[thread overview]
Message-ID: <20170617192704.GE2974@kroah.com> (raw)
In-Reply-To: <20170607170445.GC13116@dtor-ws>

On Wed, Jun 07, 2017 at 10:04:45AM -0700, Dmitry Torokhov wrote:
> On Mon, Mar 27, 2017 at 09:35:45PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Mar 27, 2017 at 10:53:59AM -0700, Dmitry Torokhov wrote:
> > > On Sun, Feb 12, 2017 at 04:36:19PM -0800, Dmitry Torokhov wrote:
> > > > Many drivers create additional driver-specific device attributes when
> > > > binding to the device and providing managed version of sysfs_create_group()
> > > > will simplify unbinding and error handling in probe path for such drivers.
> > > > 
> > > > Without managed version driver writers either have to mix manual and
> > > > managed resources, which is prone to errors, or open-code this function by
> > > > providing a wrapper to sysfs_create_group() and use it with
> > > > devm_add_action() or devm_add_action_or_reset().
> > > > 
> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > ---
> > > 
> > > Greg, gentle ping...
> > 
> > It's not lost, it's in my queue...
> 
> Another gentle ping...

Ugh, I've been hoping you would forget about this :)

But, in thinking a lot about this recently, I have now come to the same
conclusion as you, I think we really need this as there isn't a way to
handle it any other way.

So, can you rebase and resend these patches?  I don't have them in my
queue anymore and I'd like to play with them and see how they work.

thanks,

greg k-h

  reply	other threads:[~2017-06-18  0:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13  0:36 [PATCH 1/2] driver core: emit uevents when device is bound to a driver Dmitry Torokhov
2017-02-13  0:36 ` [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends Dmitry Torokhov
2017-03-27 17:53   ` Dmitry Torokhov
2017-03-27 19:35     ` Greg Kroah-Hartman
2017-06-07 17:04       ` Dmitry Torokhov
2017-06-17 19:27         ` Greg Kroah-Hartman [this message]
2017-02-13 12:07 ` [PATCH 1/2] driver core: emit uevents when device is bound to a driver Greg Kroah-Hartman
2017-02-13 18:46   ` Dmitry Torokhov
2017-02-14  0:52     ` Greg Kroah-Hartman
2017-02-14  4:22       ` Dmitry Torokhov
2017-07-18 19:30 [PATCH 0/2] New bind/unbingd uevents Dmitry Torokhov
2017-07-18 19:30 ` [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends Dmitry Torokhov
2017-07-18 20:03   ` Greg Kroah-Hartman
2017-07-18 20:26     ` Dmitry Torokhov
2017-07-19  7:34       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170617192704.GE2974@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).