* tty: define tty_open_by_driver when CONFIG_TTY is not defined
@ 2017-06-17 9:46 Okash Khawaja
2017-06-17 21:08 ` Samuel Thibault
0 siblings, 1 reply; 4+ messages in thread
From: Okash Khawaja @ 2017-06-17 9:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Samuel Thibault, linux-kernel
Cc: Alan Cox, speakup, devel
This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
defined. This was supposed to have been included in commit
12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
tty_open_by_driver"). The patch follows convention for other such
functions and returns NULL.
Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
---
include/linux/tty.h | 3 +++
1 file changed, 3 insertions(+)
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -422,6 +422,9 @@ static inline int __init tty_init(void)
{ return 0; }
static inline const char *tty_name(const struct tty_struct *tty)
{ return "(none)"; }
+static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
+ struct file *filp)
+{ return NULL; }
#endif
extern struct ktermios tty_std_termios;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: tty: define tty_open_by_driver when CONFIG_TTY is not defined
2017-06-17 9:46 tty: define tty_open_by_driver when CONFIG_TTY is not defined Okash Khawaja
@ 2017-06-17 21:08 ` Samuel Thibault
2017-06-17 21:32 ` [patch v2] " Okash Khawaja
0 siblings, 1 reply; 4+ messages in thread
From: Samuel Thibault @ 2017-06-17 21:08 UTC (permalink / raw)
To: Okash Khawaja
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-kernel, Alan Cox, speakup, devel
Okash Khawaja, on sam. 17 juin 2017 10:46:41 +0100, wrote:
> This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
> defined. This was supposed to have been included in commit
> 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
> tty_open_by_driver"). The patch follows convention for other such
> functions and returns NULL.
>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
>
> ---
> include/linux/tty.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -422,6 +422,9 @@ static inline int __init tty_init(void)
> { return 0; }
> static inline const char *tty_name(const struct tty_struct *tty)
> { return "(none)"; }
> +static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
> + struct file *filp)
> +{ return NULL; }
Add inline
Samuel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not defined
2017-06-17 21:08 ` Samuel Thibault
@ 2017-06-17 21:32 ` Okash Khawaja
2017-06-19 21:25 ` Samuel Thibault
0 siblings, 1 reply; 4+ messages in thread
From: Okash Khawaja @ 2017-06-17 21:32 UTC (permalink / raw)
To: Samuel Thibault, Greg Kroah-Hartman, Jiri Slaby, linux-kernel
Cc: Alan Cox, speakup, devel
This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
defined. This was supposed to have been included in commit
12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
tty_open_by_driver"). The patch follows convention for other such
functions and returns NULL.
Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
---
include/linux/tty.h | 3 +++
1 file changed, 3 insertions(+)
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -422,6 +422,9 @@ static inline int __init tty_init(void)
{ return 0; }
static inline const char *tty_name(const struct tty_struct *tty)
{ return "(none)"; }
+static inline struct tty_struct *tty_open_by_driver(dev_t device,
+ struct inode *inode, struct file *filp)
+{ return NULL; }
#endif
extern struct ktermios tty_std_termios;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not defined
2017-06-17 21:32 ` [patch v2] " Okash Khawaja
@ 2017-06-19 21:25 ` Samuel Thibault
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Thibault @ 2017-06-19 21:25 UTC (permalink / raw)
To: Okash Khawaja
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-kernel, Alan Cox, speakup, devel
Okash Khawaja, on sam. 17 juin 2017 22:32:55 +0100, wrote:
> This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
> defined. This was supposed to have been included in commit
> 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
> tty_open_by_driver"). The patch follows convention for other such
> functions and returns NULL.
>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> ---
> include/linux/tty.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -422,6 +422,9 @@ static inline int __init tty_init(void)
> { return 0; }
> static inline const char *tty_name(const struct tty_struct *tty)
> { return "(none)"; }
> +static inline struct tty_struct *tty_open_by_driver(dev_t device,
> + struct inode *inode, struct file *filp)
> +{ return NULL; }
> #endif
>
> extern struct ktermios tty_std_termios;
>
--
Samuel
<O> Ça peut être une madeleine à sous munitions (avec des composants,
par exemple)
-+- #runtime -+-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-19 21:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-17 9:46 tty: define tty_open_by_driver when CONFIG_TTY is not defined Okash Khawaja
2017-06-17 21:08 ` Samuel Thibault
2017-06-17 21:32 ` [patch v2] " Okash Khawaja
2017-06-19 21:25 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).