* ufs build failure (no __udivdi3) on i386 in linux tip (edf9364d3f92)
[not found] <E1dMx2x-0007xW-D8@osstest.test-lab.xenproject.org>
@ 2017-06-19 14:36 ` Ian Jackson
2017-06-19 15:08 ` Al Viro
0 siblings, 1 reply; 4+ messages in thread
From: Ian Jackson @ 2017-06-19 14:36 UTC (permalink / raw)
To: Evgeniy Dushistov
Cc: xen-devel, Linus Torvalds, Jonathan Cameron, Jens Axboe,
Alexander Viro, linux-fsdevel, linux-kernel
osstest service owner writes ("[linux-linus bisection] complete build-i386-pvops"):
> branch xen-unstable
> xenbranch xen-unstable
> job build-i386-pvops
> testid kernel-build
>
> Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
>
> *** Found and reproduced problem changeset ***
>
> Bug is in tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> Bug introduced: edf9364d3f924aff6f77176b8e52a4b68e5c30d6
> Bug not present: 791a9a666d1afe2603bcb2c6a4852d684e879252
> Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/110566/
This is a merge commit, so the bisection result is not very useful:
git-log --pretty=oneline 791a9a666d1afe2603bcb2c6a4852d684e879252..edf9364d3f924aff6f77176b8e52a4b68e5c30d6 | wc -l
2233
The error message is this:
ERROR: "__udivdi3" [fs/ufs/ufs.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
I searched the commit log and CC'd a couple of people who have fixed
similar bugs elsewhere.
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ufs build failure (no __udivdi3) on i386 in linux tip (edf9364d3f92)
2017-06-19 14:36 ` ufs build failure (no __udivdi3) on i386 in linux tip (edf9364d3f92) Ian Jackson
@ 2017-06-19 15:08 ` Al Viro
2017-06-19 17:22 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Al Viro @ 2017-06-19 15:08 UTC (permalink / raw)
To: Ian Jackson
Cc: Evgeniy Dushistov, xen-devel, Linus Torvalds, Jonathan Cameron,
Jens Axboe, linux-fsdevel, linux-kernel
On Mon, Jun 19, 2017 at 03:36:47PM +0100, Ian Jackson wrote:
> osstest service owner writes ("[linux-linus bisection] complete build-i386-pvops"):
> > branch xen-unstable
> > xenbranch xen-unstable
> > job build-i386-pvops
> > testid kernel-build
> >
> > Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> > Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
> >
> > *** Found and reproduced problem changeset ***
> >
> > Bug is in tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> > Bug introduced: edf9364d3f924aff6f77176b8e52a4b68e5c30d6
> > Bug not present: 791a9a666d1afe2603bcb2c6a4852d684e879252
> > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/110566/
>
> This is a merge commit, so the bisection result is not very useful:
>
> git-log --pretty=oneline 791a9a666d1afe2603bcb2c6a4852d684e879252..edf9364d3f924aff6f77176b8e52a4b68e5c30d6 | wc -l
> 2233
>
> The error message is this:
>
> ERROR: "__udivdi3" [fs/ufs/ufs.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
It's 64bit ->s_dsize going through "multiply by this, divide by 100".
Can be papered over by using mul_64_u32_div() in ufs_new_fragments(),
but
* expression remains unchanged, so it's better done at
mount time
* there's a braino (since circa 2002) in the same code
- the expression(s) are for the levels of fragmentation that
trigger switches in hysteresis loop and both switches lead to
the same state due to cut'n'paste damage
* for really low minfree we get those levels too close
to each other - at minfree 5 we get 0.025 .. 0.03, at minfree 4
they outright merge and below that the upper bound is less than
the lower one. We'd copied the original 4.4BSD here; at 1995
FreeBSD got switched to "minfree 5 or below means using OPTSPACE
all the time".
Fixed in vfs.git#ufs-fixes; see commit 77e9ce327d9b607cd6e57c0f4524a654dc59c4b1
there. Not sure if it's worth splitting...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ufs build failure (no __udivdi3) on i386 in linux tip (edf9364d3f92)
2017-06-19 15:08 ` Al Viro
@ 2017-06-19 17:22 ` Geert Uytterhoeven
2017-06-19 17:34 ` Al Viro
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-06-19 17:22 UTC (permalink / raw)
To: Al Viro
Cc: Ian Jackson, Evgeniy Dushistov, xen-devel, Linus Torvalds,
Jonathan Cameron, Jens Axboe, Linux FS Devel, linux-kernel,
Stephen Rothwell, Arnd Bergmann, Guenter Roeck
Hi Al,
On Mon, Jun 19, 2017 at 5:08 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> Fixed in vfs.git#ufs-fixes; see commit 77e9ce327d9b607cd6e57c0f4524a654dc59c4b1
> there. Not sure if it's worth splitting...
I can confirm that commit fixes the build for m68k.
Let's hope it fixes the build for all other 32-bit platforms, too ;-)
If I'm not mistaken, the commit that caused the breakage was never part of
linux-next before it entered mainline?
Can you please make sure all commits cook a few days in linux-next before
they are sent upstream?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ufs build failure (no __udivdi3) on i386 in linux tip (edf9364d3f92)
2017-06-19 17:22 ` Geert Uytterhoeven
@ 2017-06-19 17:34 ` Al Viro
0 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2017-06-19 17:34 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Ian Jackson, Evgeniy Dushistov, xen-devel, Linus Torvalds,
Jonathan Cameron, Jens Axboe, Linux FS Devel, linux-kernel,
Stephen Rothwell, Arnd Bergmann, Guenter Roeck
On Mon, Jun 19, 2017 at 07:22:39PM +0200, Geert Uytterhoeven wrote:
> Hi Al,
>
> On Mon, Jun 19, 2017 at 5:08 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > Fixed in vfs.git#ufs-fixes; see commit 77e9ce327d9b607cd6e57c0f4524a654dc59c4b1
> > there. Not sure if it's worth splitting...
>
> I can confirm that commit fixes the build for m68k.
> Let's hope it fixes the build for all other 32-bit platforms, too ;-)
>
> If I'm not mistaken, the commit that caused the breakage was never part of
> linux-next before it entered mainline?
> Can you please make sure all commits cook a few days in linux-next before
> they are sent upstream?
It's not an excuse, but I got too used to 0-day buildbot catching that kind
of stuff within a day or so ;-/ Should've done cross-builds myself, of course -
my fault...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-19 17:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1dMx2x-0007xW-D8@osstest.test-lab.xenproject.org>
2017-06-19 14:36 ` ufs build failure (no __udivdi3) on i386 in linux tip (edf9364d3f92) Ian Jackson
2017-06-19 15:08 ` Al Viro
2017-06-19 17:22 ` Geert Uytterhoeven
2017-06-19 17:34 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).