* [PATCH] crypto: caam: make of_device_ids const.
@ 2017-06-16 9:16 Arvind Yadav
2017-06-20 3:42 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-16 9:16 UTC (permalink / raw)
To: horia.geanta, dan.douglass, herbert, davem; +Cc: linux-crypto, linux-kernel
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2376 808 128 3312 cf0 drivers/crypto/caam/jr.o
File size after constify caam_jr_match:
text data bss dec hex filename
2976 192 128 3296 ce0 drivers/crypto/caam/jr.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/caam/jr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 2763100..1ccfb31 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -536,7 +536,7 @@ static int caam_jr_probe(struct platform_device *pdev)
return 0;
}
-static struct of_device_id caam_jr_match[] = {
+static const struct of_device_id caam_jr_match[] = {
{
.compatible = "fsl,sec-v4.0-job-ring",
},
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: caam: make of_device_ids const.
2017-06-16 9:16 [PATCH] crypto: caam: make of_device_ids const Arvind Yadav
@ 2017-06-20 3:42 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2017-06-20 3:42 UTC (permalink / raw)
To: Arvind Yadav
Cc: horia.geanta, dan.douglass, davem, linux-crypto, linux-kernel
On Fri, Jun 16, 2017 at 02:46:44PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2376 808 128 3312 cf0 drivers/crypto/caam/jr.o
>
> File size after constify caam_jr_match:
> text data bss dec hex filename
> 2976 192 128 3296 ce0 drivers/crypto/caam/jr.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-20 3:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-16 9:16 [PATCH] crypto: caam: make of_device_ids const Arvind Yadav
2017-06-20 3:42 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).