From: Petr Mladek <pmladek@suse.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: akpm@linux-foundation.org, jeyu@redhat.com, shuah@kernel.org,
rusty@rustcorp.com.au, ebiederm@xmission.com,
dmitry.torokhov@gmail.com, acme@redhat.com, corbet@lwn.net,
josh@joshtriplett.org, martin.wilck@suse.com, mmarek@suse.com,
hare@suse.com, rwright@hpe.com, jeffm@suse.com, DSterba@suse.com,
fdmanana@suse.com, neilb@suse.com, linux@roeck-us.net,
rgoldwyn@suse.com, subashab@codeaurora.org, xypron.glpk@gmx.de,
keescook@chromium.org, atomlin@redhat.com, mbenes@suse.cz,
paulmck@linux.vnet.ibm.com, dan.j.williams@intel.com,
jpoimboe@redhat.com, davem@davemloft.net, mingo@redhat.com,
alan@linux.intel.com, tytso@mit.edu, gregkh@linuxfoundation.org,
torvalds@linux-foundation.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] kmod: throttle kmod thread limit
Date: Thu, 22 Jun 2017 17:19:36 +0200 [thread overview]
Message-ID: <20170622151936.GE1538@pathway.suse.cz> (raw)
In-Reply-To: <20170526211228.27764-5-mcgrof@kernel.org>
On Fri 2017-05-26 14:12:28, Luis R. Rodriguez wrote:
> If we reach the limit of modprobe_limit threads running the next
> request_module() call will fail. The original reason for adding
> a kill was to do away with possible issues with in old circumstances
> which would create a recursive series of request_module() calls.
> We can do better than just be super aggressive and reject calls
> once we've reached the limit by simply making pending callers wait
> until the threshold has been reduced.
>
> The only difference is the clutch helps with avoiding making
> request_module() requests fatal more often. With x86_64 qemu,
> with 4 cores, 4 GiB of RAM it takes the following run time to
> run both tests:
>
> time ./kmod.sh -t 0008
> real 0m12.364s
> user 0m0.704s
> sys 0m5.373s
>
> time ./kmod.sh -t 0009
> real 0m47.638s
> user 0m1.033s
> sys 0m5.425s
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
> kernel/kmod.c | 16 +++++++---------
> tools/testing/selftests/kmod/kmod.sh | 24 ++----------------------
> 2 files changed, 9 insertions(+), 31 deletions(-)
>
> diff --git a/kernel/kmod.c b/kernel/kmod.c
> index 3e346c700e80..46b12fed6fd0 100644
> --- a/kernel/kmod.c
> +++ b/kernel/kmod.c
> @@ -163,14 +163,11 @@ int __request_module(bool wait, const char *fmt, ...)
> return ret;
>
> if (atomic_dec_if_positive(&kmod_concurrent_max) < 0) {
> - /* We may be blaming an innocent here, but unlikely */
> - if (kmod_loop_msg < 5) {
> - printk(KERN_ERR
> - "request_module: runaway loop modprobe %s\n",
> - module_name);
> - kmod_loop_msg++;
> - }
> - return -ENOMEM;
> + pr_warn_ratelimited("request_module: kmod_concurrent_max (%u) close to 0 (max_modprobes: %u), for module %s\n, throttling...",
> + atomic_read(&kmod_concurrent_max),
> + 50, module_name);
It is weird to pass the constant '50' via %s. Also a #define should be
used to keep it in sync with the kmod_concurrent_max initialization.
> + wait_event_interruptible(kmod_wq,
> + atomic_dec_if_positive(&kmod_concurrent_max) >= 0);
> }
>
> trace_module_request(module_name, wait, _RET_IP_);
> @@ -178,6 +175,7 @@ int __request_module(bool wait, const char *fmt, ...)
> ret = call_modprobe(module_name, wait ? UMH_WAIT_PROC : UMH_WAIT_EXEC);
>
> atomic_inc(&kmod_concurrent_max);
> + wake_up_all(&kmod_wq);
Does it make sense to wake up all waiters when we released the resource
only for one? IMHO, a simple wake_up() should be here.
I am sorry for the late review. The month ran really fast.
Best Regards,
Petr
next prev parent reply other threads:[~2017-06-22 15:19 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 3:24 [PATCH 0/6] kmod: few simple enhancements Luis R. Rodriguez
2017-05-19 3:24 ` [PATCH 1/6] kmod: add dynamic max concurrent thread count Luis R. Rodriguez
2017-05-19 20:44 ` Dmitry Torokhov
[not found] ` <CAB=NE6XGL24O+JfTNUG0HO4obhDc-v+HyL0SCrQELiZrj2-qNw@mail.gmail.com>
[not found] ` <CAB=NE6Wa4Nemh80yaCCwbjrNRLPD+GJMncg12APg9Vq63AWVng@mail.gmail.com>
[not found] ` <CAB=NE6Vc6RDAytn2Pkv2V58HFo8ncR0eOHZ3===kbZ2NF78ubg@mail.gmail.com>
[not found] ` <CAB=NE6Vqmx=y6muenpuQKynTP=pGWMF8tzoCA0BXD6d63q9wPg@mail.gmail.com>
2017-05-19 21:58 ` Dmitry Torokhov
2017-05-25 16:22 ` Luis R. Rodriguez
2017-05-25 16:38 ` Dmitry Torokhov
2017-05-25 16:50 ` Luis R. Rodriguez
2017-05-25 17:30 ` Dmitry Torokhov
2017-05-25 17:38 ` Luis R. Rodriguez
2017-05-25 18:06 ` Luis R. Rodriguez
2017-05-25 18:26 ` Dmitry Torokhov
2017-05-25 19:01 ` Luis R. Rodriguez
2017-05-25 21:38 ` Luis R. Rodriguez
2017-05-19 3:24 ` [PATCH 2/6] module: use list_for_each_entry_rcu() on find_module_all() Luis R. Rodriguez
2017-05-23 14:46 ` Miroslav Benes
2017-05-19 3:24 ` [PATCH 3/6] kmod: provide wrappers for kmod_concurrent inc/dec Luis R. Rodriguez
2017-05-19 3:24 ` [PATCH 4/6] kmod: return -EBUSY if modprobe limit is reached Luis R. Rodriguez
2017-05-19 3:24 ` [PATCH 5/6] kmod: preempt on kmod_umh_threads_get() Luis R. Rodriguez
2017-05-19 22:27 ` Dmitry Torokhov
2017-05-25 0:14 ` Luis R. Rodriguez
2017-05-25 0:45 ` Dmitry Torokhov
2017-05-25 1:00 ` Luis R. Rodriguez
2017-05-25 2:27 ` Dmitry Torokhov
2017-05-25 11:19 ` Petr Mladek
2017-05-25 15:38 ` Luis R. Rodriguez
2017-05-25 16:42 ` Dmitry Torokhov
2017-05-25 15:18 ` Jessica Yu
2017-05-19 3:24 ` [PATCH 6/6] kmod: use simplified rate limit printk Luis R. Rodriguez
2017-05-19 22:23 ` Dmitry Torokhov
2017-05-23 9:00 ` Petr Mladek
2017-05-26 0:16 ` [PATCH v2 0/5] kmod: help make deterministic Luis R. Rodriguez
2017-05-26 0:16 ` [PATCH v2 1/5] module: use list_for_each_entry_rcu() on find_module_all() Luis R. Rodriguez
2017-05-26 0:16 ` [PATCH v2 2/5] kmod: reduce atomic operations on kmod_concurrent Luis R. Rodriguez
2017-05-26 1:11 ` Dmitry Torokhov
2017-05-26 20:03 ` Luis R. Rodriguez
2017-05-26 0:16 ` [PATCH v2 3/5] kmod: add test driver to stress test the module loader Luis R. Rodriguez
2017-05-26 0:16 ` [PATCH v2 4/5] kmod: add helpers for getting kmod limit Luis R. Rodriguez
2017-05-26 0:56 ` Dmitry Torokhov
2017-05-26 20:27 ` Luis R. Rodriguez
2017-05-26 0:16 ` [PATCH v2 5/5] kmod: throttle kmod thread limit Luis R. Rodriguez
2017-05-26 21:12 ` [PATCH v3 0/4] kmod: help make deterministic Luis R. Rodriguez
2017-05-26 21:12 ` [PATCH v3 1/4] module: use list_for_each_entry_rcu() on find_module_all() Luis R. Rodriguez
2017-05-26 21:12 ` [PATCH v3 2/4] kmod: reduce atomic operations on kmod_concurrent and simplify Luis R. Rodriguez
2017-06-23 19:19 ` [PATCH v4 " Luis R. Rodriguez
2017-06-26 11:36 ` [PATCH v3 " Petr Mladek
2017-05-26 21:12 ` [PATCH v3 3/4] kmod: add test driver to stress test the module loader Luis R. Rodriguez
2017-05-26 21:12 ` [PATCH v3 4/4] kmod: throttle kmod thread limit Luis R. Rodriguez
2017-06-22 15:19 ` Petr Mladek [this message]
2017-06-23 16:16 ` Luis R. Rodriguez
2017-06-23 17:56 ` Luis R. Rodriguez
2017-06-23 19:16 ` Luis R. Rodriguez
2017-06-26 10:03 ` Petr Mladek
2017-06-26 9:55 ` Petr Mladek
2017-06-23 19:20 ` [PATCH v4 " Luis R. Rodriguez
2017-06-26 11:38 ` Petr Mladek
2017-06-28 22:11 ` Luis R. Rodriguez
2017-06-20 20:56 ` [PATCH v3 0/4] kmod: help make deterministic Luis R. Rodriguez
2017-06-21 0:23 ` Kees Cook
2017-06-26 21:37 ` Jessica Yu
2017-06-26 22:44 ` Luis R. Rodriguez
2017-06-27 0:27 ` Luis R. Rodriguez
2017-06-27 8:13 ` Petr Mladek
2017-06-27 10:04 ` Jessica Yu
2017-06-27 15:26 ` Jessica Yu
2017-06-28 0:49 ` Luis R. Rodriguez
2017-06-28 22:31 ` [PATCH v4 0/3] " Luis R. Rodriguez
2017-06-28 22:31 ` [PATCH v4 1/3] MAINTAINERS: give kmod some maintainer love Luis R. Rodriguez
2017-06-28 22:31 ` [PATCH v4 2/3] kmod: add test driver to stress test the module loader Luis R. Rodriguez
2017-06-28 22:31 ` [PATCH v4 3/3] kmod: throttle kmod thread limit Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622151936.GE1538@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=DSterba@suse.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=atomlin@redhat.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=ebiederm@xmission.com \
--cc=fdmanana@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=jeffm@suse.com \
--cc=jeyu@redhat.com \
--cc=josh@joshtriplett.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.wilck@suse.com \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.com \
--cc=neilb@suse.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rgoldwyn@suse.com \
--cc=rusty@rustcorp.com.au \
--cc=rwright@hpe.com \
--cc=shuah@kernel.org \
--cc=subashab@codeaurora.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).