* [PATCH] scsi: hptiop: make function hptiop_iop_request_callback_itl static
@ 2017-06-22 15:52 Colin King
2017-06-26 17:32 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-06-22 15:52 UTC (permalink / raw)
To: HighPoint Linux Team, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function hptiop_iop_request_callback_itl does not need to be in
global scope, so make it static.
Cleans up sparse warning:
"symbol 'hptiop_iop_request_callback_itl' was not declared. Should it
be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/hptiop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
index db17ad15b0c1..7226226f7383 100644
--- a/drivers/scsi/hptiop.c
+++ b/drivers/scsi/hptiop.c
@@ -800,7 +800,7 @@ static void hptiop_host_request_callback_itl(struct hptiop_hba *hba, u32 _tag)
hptiop_finish_scsi_req(hba, tag, req);
}
-void hptiop_iop_request_callback_itl(struct hptiop_hba *hba, u32 tag)
+static void hptiop_iop_request_callback_itl(struct hptiop_hba *hba, u32 tag)
{
struct hpt_iop_request_header __iomem *req;
struct hpt_iop_request_ioctl_command __iomem *p;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: hptiop: make function hptiop_iop_request_callback_itl static
2017-06-22 15:52 [PATCH] scsi: hptiop: make function hptiop_iop_request_callback_itl static Colin King
@ 2017-06-26 17:32 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2017-06-26 17:32 UTC (permalink / raw)
To: Colin King
Cc: HighPoint Linux Team, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
Colin,
> The function hptiop_iop_request_callback_itl does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> "symbol 'hptiop_iop_request_callback_itl' was not declared. Should it
> be static?"
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-26 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 15:52 [PATCH] scsi: hptiop: make function hptiop_iop_request_callback_itl static Colin King
2017-06-26 17:32 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).