From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media
Date: Sat, 24 Jun 2017 17:15:07 -0300 [thread overview]
Message-ID: <20170624171507.38353b10@vento.lan> (raw)
In-Reply-To: <20170621080812.6817-1-jthumshirn@suse.de>
Em Wed, 21 Jun 2017 10:08:05 +0200
Johannes Thumshirn <jthumshirn@suse.de> escreveu:
> Currently the media subsystem has a very creative abuse of the
> KERNEL_VERSION macro to encode an arbitrary version triplet for media
> drivers and device hardware revisions.
>
> This series introduces a new macro called MEDIA_REVISION which encodes
> a version triplet like KERNEL_VERSION does, but clearly has media
> centric semantics and doesn't fool someone into thinking specific
> parts are defined for a specific kernel version only like in out of
> tree drivers.
Sorry, but I can't see any advantage on it. On the downside, it
includes the media controller header file (media.h) where it
is not needed.
>
> Johannes Thumshirn (7):
> [media] media: introduce MEDIA_REVISION macro
> video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION
> [media] media: document the use of MEDIA_REVISION instead of
> KERNEL_VERSION
> [media] cx25821: use MEDIA_REVISION instead of KERNEL_VERSION
> [media] media: s3c-camif: Use MEDIA_REVISON instead of KERNEL_VERSION
> [media] media: bcm2048: use MEDIA_REVISION isntead of KERNEL_VERSION
> staging/atomisp: use MEDIA_VERSION instead of KERNEL_VERSION
That's said, some of the above shouldn't be using KERNEL_VERSION
at all. The V4L2 core sets the version already. So, drivers like
cx25821, s3c-camif, bcm2048 and atomisp are likely doing the wrong
thing.
Thanks,
Mauro
next prev parent reply other threads:[~2017-06-24 20:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 8:08 [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 1/7] [media] media: introduce MEDIA_REVISION macro Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 2/7] video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 3/7] [media] media: document the use of MEDIA_REVISION instead of KERNEL_VERSION Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 4/7] [media] cx25821: use " Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 5/7] [media] media: s3c-camif: Use MEDIA_REVISON " Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 6/7] [media] media: bcm2048: use MEDIA_REVISION isntead " Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 7/7] staging/atomisp: use MEDIA_VERSION instead " Johannes Thumshirn
2017-06-24 20:15 ` Mauro Carvalho Chehab [this message]
2017-06-29 9:42 ` [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media Johannes Thumshirn
2017-06-29 17:01 ` Stephen Hemminger
2017-06-30 7:27 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170624171507.38353b10@vento.lan \
--to=mchehab@s-opensource.com \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=hans.verkuil@cisco.com \
--cc=jthumshirn@suse.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).