From: Stephen Hemminger <stephen@networkplumber.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media
Date: Thu, 29 Jun 2017 10:01:05 -0700 [thread overview]
Message-ID: <20170629100105.6af3b77a@xeon-e3> (raw)
In-Reply-To: <20170629094259.GG3808@linux-x5ow.site>
On Thu, 29 Jun 2017 11:42:59 +0200
Johannes Thumshirn <jthumshirn@suse.de> wrote:
> On Sat, Jun 24, 2017 at 05:15:07PM -0300, Mauro Carvalho Chehab wrote:
> > Sorry, but I can't see any advantage on it. On the downside, it
> > includes the media controller header file (media.h) where it
> > is not needed.
>
> My reasoning was the differences in semantics. KERNEL_VERSION() is for
> encoding the kernel's version triplet not a API or Hardware or whatever
> version. Other subsystems do this as well, for instance in NVMe we have the
> NVME_VS() macro which is used to encode the NVMe Spec compliance from a human
> readable form to the hardware's u32. Also KERNEL_VERISON() shouldn't have
> in-tree users IMHO. Yes there is _one_ other user of it in-tree which is EXT4
> and I already talked to Jan Kara about it and we decided to leave it in until
> 4.20.
>
> Byte,
> Johannes
If you read Linus's comments on version.
Driver version is meaningless and there is a desire to rip it out of all
drivers. The reason is that drivers must always behave the same, i.e you
can't use version to change API/ABI behavior.
Any upstream driver should never use KERNEL_VERSION().
next prev parent reply other threads:[~2017-06-29 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 8:08 [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 1/7] [media] media: introduce MEDIA_REVISION macro Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 2/7] video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 3/7] [media] media: document the use of MEDIA_REVISION instead of KERNEL_VERSION Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 4/7] [media] cx25821: use " Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 5/7] [media] media: s3c-camif: Use MEDIA_REVISON " Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 6/7] [media] media: bcm2048: use MEDIA_REVISION isntead " Johannes Thumshirn
2017-06-21 8:08 ` [PATCH RESEND 7/7] staging/atomisp: use MEDIA_VERSION instead " Johannes Thumshirn
2017-06-24 20:15 ` [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media Mauro Carvalho Chehab
2017-06-29 9:42 ` Johannes Thumshirn
2017-06-29 17:01 ` Stephen Hemminger [this message]
2017-06-30 7:27 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629100105.6af3b77a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=hans.verkuil@cisco.com \
--cc=jthumshirn@suse.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).