* [PATCH 0/2] Enable USB dual-role operation for TM2 and TM2E
[not found] <CGME20170620071229epcas1p4076c72c941527ef3073e4036a7421cfb@epcas1p4.samsung.com>
@ 2017-06-20 7:12 ` Dongwoo Lee
[not found] ` <CGME20170620071230epcas5p497144c7ccd8485da9109b8905a5ea36e@epcas5p4.samsung.com>
[not found] ` <CGME20170620071232epcas1p44dcc6475c7f826a8da52ad776759a926@epcas1p4.samsung.com>
0 siblings, 2 replies; 6+ messages in thread
From: Dongwoo Lee @ 2017-06-20 7:12 UTC (permalink / raw)
Cc: cw00.choi, andi.shyti, Dongwoo Lee
Since commit 9840354ff429 ("usb: dwc3: Add dual-role support") USB
dual-role operation on TM2 and TM2E can be enabled by simply adding
extcon property. However, exynos5433 dt has the mislabeled dwc3 node,
and thus we should resolve it first to apply the property.
This patchset fixes up the device tree fault and adds extcon property
to activate dual-role operation.
Dongwoo Lee (2):
arm64: dts: exynos: Fix wrong label for USB 3.0 controller node
arm64: dts: exynos: Add extcon property for TM2 and TM2E
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 3 ++-
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: dts: exynos: Fix wrong label for USB 3.0 controller node
[not found] ` <CGME20170620071230epcas5p497144c7ccd8485da9109b8905a5ea36e@epcas5p4.samsung.com>
@ 2017-06-20 7:12 ` Dongwoo Lee
2017-06-24 18:16 ` Krzysztof Kozlowski
2017-07-18 5:06 ` Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Dongwoo Lee @ 2017-06-20 7:12 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Kukjin Kim, Krzysztof Kozlowski,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, open list
Cc: cw00.choi, andi.shyti, Dongwoo Lee
Exynos5433 has two usb 3.0 controllers: usbhost and usbdrd. usbhost
is host-only controller whereas usbdrd supports both peripheral and
host mode. "drd" means dual-role device, so usbhost cannot be labeled
with the name contains "drd". Howerver, the label usbdrd_dwc3_0 was
used for usbhost's dwc3 node. It seems it obviously fault because TM2
and TM2E doesn't use usbhost but dr_mode property is assigned to it.
This patch assigns the proper label for two dwc3 nodes, and apply
changes to the related reference.
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 804a270..477c3bc 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -1202,7 +1202,7 @@
status = "okay";
};
-&usbdrd_dwc3_0 {
+&usbdrd_dwc3 {
dr_mode = "otg";
};
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 727f36a..7fe994b 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1367,7 +1367,7 @@
ranges;
status = "disabled";
- dwc3@15400000 {
+ usbdrd_dwc3: dwc3@15400000 {
compatible = "snps,dwc3";
reg = <0x15400000 0x10000>;
interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
@@ -1414,7 +1414,7 @@
ranges;
status = "disabled";
- usbdrd_dwc3_0: dwc3@15a00000 {
+ usbhost_dwc3: dwc3@15a00000 {
compatible = "snps,dwc3";
reg = <0x15a00000 0x10000>;
interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: exynos: Add extcon property for TM2 and TM2E
[not found] ` <CGME20170620071232epcas1p44dcc6475c7f826a8da52ad776759a926@epcas1p4.samsung.com>
@ 2017-06-20 7:12 ` Dongwoo Lee
2017-07-18 5:07 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Dongwoo Lee @ 2017-06-20 7:12 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Kukjin Kim, Krzysztof Kozlowski,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, open list
Cc: cw00.choi, andi.shyti, Dongwoo Lee
Since commit 9840354ff429 ("usb: dwc3: Add dual-role support") dwc3
node requires extcon property to be initialized as otg mode, and it
can support dual-role mode operation.
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 477c3bc..4daca1e 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -1204,6 +1204,7 @@
&usbdrd_dwc3 {
dr_mode = "otg";
+ extcon = <&muic>;
};
&usbdrd30_phy {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: exynos: Fix wrong label for USB 3.0 controller node
2017-06-20 7:12 ` [PATCH 1/2] arm64: dts: exynos: Fix wrong label for USB 3.0 controller node Dongwoo Lee
@ 2017-06-24 18:16 ` Krzysztof Kozlowski
2017-07-18 5:06 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2017-06-24 18:16 UTC (permalink / raw)
To: Dongwoo Lee
Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Kukjin Kim,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, open list,
cw00.choi, andi.shyti
On Tue, Jun 20, 2017 at 04:12:23PM +0900, Dongwoo Lee wrote:
> Exynos5433 has two usb 3.0 controllers: usbhost and usbdrd. usbhost
> is host-only controller whereas usbdrd supports both peripheral and
> host mode. "drd" means dual-role device, so usbhost cannot be labeled
> with the name contains "drd". Howerver, the label usbdrd_dwc3_0 was
Patch looks okay but it is too late for current cycle so I will take it
for v4.14. In future, please run spell check :)
Best regards,
Krzysztof
> used for usbhost's dwc3 node. It seems it obviously fault because TM2
> and TM2E doesn't use usbhost but dr_mode property is assigned to it.
>
> This patch assigns the proper label for two dwc3 nodes, and apply
> changes to the related reference
>
> Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 804a270..477c3bc 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -1202,7 +1202,7 @@
> status = "okay";
> };
>
> -&usbdrd_dwc3_0 {
> +&usbdrd_dwc3 {
> dr_mode = "otg";
> };
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 727f36a..7fe994b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1367,7 +1367,7 @@
> ranges;
> status = "disabled";
>
> - dwc3@15400000 {
> + usbdrd_dwc3: dwc3@15400000 {
> compatible = "snps,dwc3";
> reg = <0x15400000 0x10000>;
> interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1414,7 +1414,7 @@
> ranges;
> status = "disabled";
>
> - usbdrd_dwc3_0: dwc3@15a00000 {
> + usbhost_dwc3: dwc3@15a00000 {
> compatible = "snps,dwc3";
> reg = <0x15a00000 0x10000>;
> interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: exynos: Fix wrong label for USB 3.0 controller node
2017-06-20 7:12 ` [PATCH 1/2] arm64: dts: exynos: Fix wrong label for USB 3.0 controller node Dongwoo Lee
2017-06-24 18:16 ` Krzysztof Kozlowski
@ 2017-07-18 5:06 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2017-07-18 5:06 UTC (permalink / raw)
To: Dongwoo Lee
Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Kukjin Kim,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, open list,
cw00.choi, andi.shyti
On Tue, Jun 20, 2017 at 04:12:23PM +0900, Dongwoo Lee wrote:
> Exynos5433 has two usb 3.0 controllers: usbhost and usbdrd. usbhost
> is host-only controller whereas usbdrd supports both peripheral and
> host mode. "drd" means dual-role device, so usbhost cannot be labeled
> with the name contains "drd". Howerver, the label usbdrd_dwc3_0 was
> used for usbhost's dwc3 node. It seems it obviously fault because TM2
> and TM2E doesn't use usbhost but dr_mode property is assigned to it.
>
> This patch assigns the proper label for two dwc3 nodes, and apply
> changes to the related reference.
>
> Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: exynos: Add extcon property for TM2 and TM2E
2017-06-20 7:12 ` [PATCH 2/2] arm64: dts: exynos: Add extcon property for TM2 and TM2E Dongwoo Lee
@ 2017-07-18 5:07 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2017-07-18 5:07 UTC (permalink / raw)
To: Dongwoo Lee
Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Kukjin Kim,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, open list,
cw00.choi, andi.shyti
On Tue, Jun 20, 2017 at 04:12:24PM +0900, Dongwoo Lee wrote:
> Since commit 9840354ff429 ("usb: dwc3: Add dual-role support") dwc3
> node requires extcon property to be initialized as otg mode, and it
> can support dual-role mode operation.
>
> Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-18 5:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170620071229epcas1p4076c72c941527ef3073e4036a7421cfb@epcas1p4.samsung.com>
2017-06-20 7:12 ` [PATCH 0/2] Enable USB dual-role operation for TM2 and TM2E Dongwoo Lee
[not found] ` <CGME20170620071230epcas5p497144c7ccd8485da9109b8905a5ea36e@epcas5p4.samsung.com>
2017-06-20 7:12 ` [PATCH 1/2] arm64: dts: exynos: Fix wrong label for USB 3.0 controller node Dongwoo Lee
2017-06-24 18:16 ` Krzysztof Kozlowski
2017-07-18 5:06 ` Krzysztof Kozlowski
[not found] ` <CGME20170620071232epcas1p44dcc6475c7f826a8da52ad776759a926@epcas1p4.samsung.com>
2017-06-20 7:12 ` [PATCH 2/2] arm64: dts: exynos: Add extcon property for TM2 and TM2E Dongwoo Lee
2017-07-18 5:07 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).