* [PATCH] sony-laptop: constify sony_laptop_input_* and spic_attribute_group
@ 2017-06-23 8:56 Arvind Yadav
2017-06-24 14:57 ` kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-23 8:56 UTC (permalink / raw)
To: malattia, dvhart, andy; +Cc: platform-driver-x86, linux-kernel
File size before:
text data bss dec hex filename
31273 5176 372 36821 8fd5 drivers/platform/x86/sony-laptop.o
File size After adding 'const':
text data bss dec hex filename
31593 4856 372 36821 8fd5 drivers/platform/x86/sony-laptop.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/platform/x86/sony-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index aa2ee51..5fc2047 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -222,7 +222,7 @@ struct sony_laptop_keypress {
/* Correspondance table between sonypi events
* and input layer indexes in the keymap
*/
-static int sony_laptop_input_index[] = {
+static const int sony_laptop_input_index[] = {
-1, /* 0 no event */
-1, /* 1 SONYPI_EVENT_JOGDIAL_DOWN */
-1, /* 2 SONYPI_EVENT_JOGDIAL_UP */
@@ -299,7 +299,7 @@ struct sony_laptop_keypress {
59, /* 72 SONYPI_EVENT_VENDOR_PRESSED */
};
-static int sony_laptop_input_keycode_map[] = {
+static const int sony_laptop_input_keycode_map[] = {
KEY_CAMERA, /* 0 SONYPI_EVENT_CAPTURE_PRESSED */
KEY_RESERVED, /* 1 SONYPI_EVENT_CAPTURE_RELEASED */
KEY_RESERVED, /* 2 SONYPI_EVENT_CAPTURE_PARTIALPRESSED */
@@ -4032,7 +4032,7 @@ struct device_attribute spic_attr_##_name = __ATTR(_name, \
NULL
};
-static struct attribute_group spic_attribute_group = {
+static const struct attribute_group spic_attribute_group = {
.attrs = spic_attributes
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sony-laptop: constify sony_laptop_input_* and spic_attribute_group
2017-06-23 8:56 [PATCH] sony-laptop: constify sony_laptop_input_* and spic_attribute_group Arvind Yadav
@ 2017-06-24 14:57 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2017-06-24 14:57 UTC (permalink / raw)
To: Arvind Yadav
Cc: kbuild-all, malattia, dvhart, andy, platform-driver-x86, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 4264 bytes --]
Hi Arvind,
[auto build test WARNING on platform-drivers-x86/for-next]
[also build test WARNING on v4.12-rc6 next-20170623]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Arvind-Yadav/sony-laptop-constify-sony_laptop_input_-and-spic_attribute_group/20170624-221228
base: git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-next
config: x86_64-randconfig-x007-201725 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
>> drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
key_dev->keycode = &sony_laptop_input_keycode_map;
^
vim +/const +494 drivers/platform/x86/sony-laptop.c
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 478 if (!key_dev) {
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 479 error = -ENOMEM;
9593bd07 drivers/platform/x86/sony-laptop.c Dmitry Torokhov 2009-12-24 480 goto err_free_kfifo;
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 481 }
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 482
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 483 key_dev->name = "Sony Vaio Keys";
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 484 key_dev->id.bustype = BUS_ISA;
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 485 key_dev->id.vendor = PCI_VENDOR_ID_SONY;
2e4d242c drivers/misc/sony-laptop.c Dmitry Torokhov 2007-11-21 486 key_dev->dev.parent = &acpi_device->dev;
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 487
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 488 /* Initialize the Input Drivers: special keys */
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov 2009-12-24 489 input_set_capability(key_dev, EV_MSC, MSC_SCAN);
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov 2009-12-24 490
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov 2009-12-24 491 __set_bit(EV_KEY, key_dev->evbit);
bc57f865 drivers/misc/sony-laptop.c Mattia Dongili 2007-07-20 492 key_dev->keycodesize = sizeof(sony_laptop_input_keycode_map[0]);
bc57f865 drivers/misc/sony-laptop.c Mattia Dongili 2007-07-20 493 key_dev->keycodemax = ARRAY_SIZE(sony_laptop_input_keycode_map);
bc57f865 drivers/misc/sony-laptop.c Mattia Dongili 2007-07-20 @494 key_dev->keycode = &sony_laptop_input_keycode_map;
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov 2009-12-24 495 for (i = 0; i < ARRAY_SIZE(sony_laptop_input_keycode_map); i++)
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov 2009-12-24 496 __set_bit(sony_laptop_input_keycode_map[i], key_dev->keybit);
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov 2009-12-24 497 __clear_bit(KEY_RESERVED, key_dev->keybit);
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 498
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 499 error = input_register_device(key_dev);
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 500 if (error)
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 501 goto err_free_keydev;
1549ee6f drivers/misc/sony-laptop.c malattia@linux.it 2007-04-09 502
:::::: The code at line 494 was first introduced by commit
:::::: bc57f865fa2282ad2b7efe02da0a752e602e982e sony-laptop: Make the driver use MSC_SCAN and a setkeycode and getkeycode key table.
:::::: TO: Mattia Dongili <malattia@linux.it>
:::::: CC: Len Brown <len.brown@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29885 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-24 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 8:56 [PATCH] sony-laptop: constify sony_laptop_input_* and spic_attribute_group Arvind Yadav
2017-06-24 14:57 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).