From: kbuild test robot <lkp@intel.com>
To: Hugues Fruchet <hugues.fruchet@st.com>
Cc: kbuild-all@01.org,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Yannick Fertre <yannick.fertre@st.com>,
Hugues Fruchet <hugues.fruchet@st.com>
Subject: Re: [PATCH v1 5/6] [media] ov9650: add multiple variant support
Date: Sun, 25 Jun 2017 20:36:44 +0800 [thread overview]
Message-ID: <201706252047.pFxzMQ74%fengguang.wu@intel.com> (raw)
In-Reply-To: <1498143942-12682-6-git-send-email-hugues.fruchet@st.com>
[-- Attachment #1: Type: text/plain, Size: 6623 bytes --]
Hi Hugues,
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.12-rc6 next-20170623]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Hugues-Fruchet/Add-support-of-OV9655-camera/20170625-201153
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-x079-06251032 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/media//i2c/ov9650.c: In function 'ov965x_probe':
>> drivers/media//i2c/ov9650.c:1617:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (ov965x->initialize_controls)
^~
drivers/media//i2c/ov9650.c:1619:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if (ret < 0)
^~
Cyclomatic Complexity 1 include/linux/err.h:PTR_ERR
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:fls
Cyclomatic Complexity 1 include/linux/device.h:dev_get_drvdata
Cyclomatic Complexity 1 include/asm-generic/gpio.h:gpio_is_valid
Cyclomatic Complexity 1 include/linux/i2c.h:i2c_get_clientdata
Cyclomatic Complexity 1 include/media/media-entity.h:media_entity_cleanup
Cyclomatic Complexity 1 include/media/v4l2-subdev.h:v4l2_get_subdevdata
Cyclomatic Complexity 1 drivers/media//i2c/ov9650.c:ctrl_to_sd
Cyclomatic Complexity 1 drivers/media//i2c/ov9650.c:to_ov965x
Cyclomatic Complexity 1 drivers/media//i2c/ov9650.c:ov965x_get_default_format
Cyclomatic Complexity 2 drivers/media//i2c/ov9650.c:ov965x_enum_mbus_code
Cyclomatic Complexity 4 drivers/media//i2c/ov9650.c:ov965x_enum_frame_sizes
Cyclomatic Complexity 6 drivers/media//i2c/ov9650.c:__ov965x_try_frame_size
Cyclomatic Complexity 1 drivers/media//i2c/ov9650.c:ov965x_i2c_driver_init
Cyclomatic Complexity 1 drivers/media//i2c/ov9650.c:ov965x_remove
Cyclomatic Complexity 8 drivers/media//i2c/ov9650.c:__ov965x_set_frame_interval
Cyclomatic Complexity 5 drivers/media//i2c/ov9650.c:ov965x_read
Cyclomatic Complexity 11 drivers/media//i2c/ov9650.c:__g_volatile_ctrl
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_write
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_write_array
Cyclomatic Complexity 2 drivers/media//i2c/ov9650.c:ov965x_set_frame_size
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_set_default_gamma_curve
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_set_color_matrix
Cyclomatic Complexity 5 drivers/media//i2c/ov9650.c:ov965x_set_white_balance
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_set_brightness
Cyclomatic Complexity 12 drivers/media//i2c/ov9650.c:ov965x_set_gain
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_set_flip
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_set_saturation
Cyclomatic Complexity 6 drivers/media//i2c/ov9650.c:ov965x_set_sharpness
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_set_test_pattern
Cyclomatic Complexity 7 drivers/media//i2c/ov9650.c:ov965x_set_banding_filter
Cyclomatic Complexity 10 drivers/media//i2c/ov9650.c:__ov965x_set_params
Cyclomatic Complexity 1 include/linux/err.h:IS_ERR
Cyclomatic Complexity 1 include/media/v4l2-ctrls.h:v4l2_ctrl_lock
Cyclomatic Complexity 1 include/media/v4l2-ctrls.h:v4l2_ctrl_unlock
Cyclomatic Complexity 2 drivers/media//i2c/ov9650.c:ov965x_g_volatile_ctrl
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_s_frame_interval
Cyclomatic Complexity 2 drivers/media//i2c/ov9650.c:ov965x_g_frame_interval
Cyclomatic Complexity 1 include/media/v4l2-ctrls.h:v4l2_ctrl_modify_range
Cyclomatic Complexity 7 drivers/media//i2c/ov9650.c:ov965x_update_exposure_ctrl
Cyclomatic Complexity 3 drivers/media//i2c/ov9650.c:ov965x_initialize_controls
Cyclomatic Complexity 10 drivers/media//i2c/ov9650.c:ov965x_set_exposure
Cyclomatic Complexity 12 drivers/media//i2c/ov9650.c:ov965x_s_ctrl
Cyclomatic Complexity 1 include/media/v4l2-subdev.h:v4l2_subdev_get_try_format
Cyclomatic Complexity 1 drivers/media//i2c/ov9650.c:ov965x_open
Cyclomatic Complexity 11 drivers/media//i2c/ov9650.c:ov965x_set_fmt
Cyclomatic Complexity 2 drivers/media//i2c/ov9650.c:ov965x_get_fmt
Cyclomatic Complexity 13 drivers/media//i2c/ov9650.c:ov965x_s_stream
Cyclomatic Complexity 2 drivers/media//i2c/ov9650.c:ov965x_gpio_set
Cyclomatic Complexity 2 drivers/media//i2c/ov9650.c:__ov965x_set_power
Cyclomatic Complexity 7 drivers/media//i2c/ov9650.c:ov965x_s_power
Cyclomatic Complexity 4 drivers/media//i2c/ov9650.c:ov965x_detect_sensor
Cyclomatic Complexity 1 include/linux/device.h:devm_kzalloc
Cyclomatic Complexity 1 include/asm-generic/gpio.h:__gpio_set_value
Cyclomatic Complexity 1 include/linux/gpio.h:gpio_set_value
Cyclomatic Complexity 1 include/asm-generic/gpio.h:gpio_export
Cyclomatic Complexity 5 drivers/media//i2c/ov9650.c:ov965x_configure_gpios
Cyclomatic Complexity 14 drivers/media//i2c/ov9650.c:ov965x_probe
Cyclomatic Complexity 1 drivers/media//i2c/ov9650.c:ov965x_i2c_driver_exit
vim +/if +1617 drivers/media//i2c/ov9650.c
1601 ov965x->init_regs = ov965x_init_regs;
1602 ov965x->initialize_controls = ov965x_initialize_controls;
1603 ov965x->framesizes = ov965x_framesizes;
1604 ov965x->nb_of_framesizes = ARRAY_SIZE(ov965x_framesizes);
1605 ov965x->formats = ov965x_formats;
1606 ov965x->nb_of_formats = ARRAY_SIZE(ov965x_formats);
1607 ov965x->intervals = ov965x_intervals;
1608 ov965x->nb_of_intervals = ARRAY_SIZE(ov965x_intervals);
1609 ov965x->fiv = &ov965x_intervals[0];
1610 ov965x->set_frame_interval = __ov965x_set_frame_interval;
1611 ov965x->update_exposure_ctrl = ov965x_update_exposure_ctrl;
1612 ov965x->set_params = __ov965x_set_params;
1613
1614 ov965x->frame_size = &ov965x->framesizes[0];
1615 ov965x_get_default_format(ov965x, &ov965x->format);
1616
> 1617 if (ov965x->initialize_controls)
1618 ret = ov965x->initialize_controls(ov965x);
1619 if (ret < 0)
1620 goto err_ctrls;
1621
1622 /* Update exposure time min/max to match frame format */
1623 if (ov965x->update_exposure_ctrl)
1624 ov965x->update_exposure_ctrl(ov965x);
1625
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24934 bytes --]
next prev parent reply other threads:[~2017-06-25 12:36 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 15:05 [PATCH v1 0/6] Add support of OV9655 camera Hugues Fruchet
2017-06-22 15:05 ` [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module Hugues Fruchet
2017-06-23 10:25 ` H. Nikolaus Schaller
2017-06-23 10:46 ` Andreas Färber
2017-06-23 10:59 ` H. Nikolaus Schaller
2017-06-23 11:58 ` Laurent Pinchart
2017-06-23 14:53 ` H. Nikolaus Schaller
2017-06-23 14:57 ` Andreas Färber
2017-06-23 15:22 ` H. Nikolaus Schaller
2017-06-23 18:05 ` Suman Anna
2017-06-23 18:59 ` H. Nikolaus Schaller
2017-06-23 22:24 ` Suman Anna
2017-06-26 6:00 ` H. Nikolaus Schaller
2017-06-26 10:35 ` Hugues FRUCHET
2017-06-26 20:04 ` Sylwester Nawrocki
2017-06-27 5:48 ` H. Nikolaus Schaller
2017-06-27 22:57 ` Sylwester Nawrocki
2017-06-28 9:12 ` H. Nikolaus Schaller
2017-06-28 10:50 ` Sylwester Nawrocki
2017-06-28 11:24 ` H. Nikolaus Schaller
2017-06-28 12:28 ` Hugues FRUCHET
2017-06-26 18:56 ` Rob Herring
2017-06-26 18:54 ` Rob Herring
2017-06-22 15:05 ` [PATCH v1 2/6] [media] ov9650: add device tree support Hugues Fruchet
2017-06-26 16:31 ` Sakari Ailus
2017-06-26 17:46 ` H. Nikolaus Schaller
2017-06-27 5:36 ` Sakari Ailus
2017-06-27 10:14 ` Hugues FRUCHET
2017-06-22 15:05 ` [PATCH v1 3/6] [media] ov9650: select the nearest higher resolution Hugues Fruchet
2017-06-22 15:05 ` [PATCH v1 4/6] [media] ov9650: use write_array() for resolution sequences Hugues Fruchet
2017-06-26 16:33 ` Sakari Ailus
2017-06-29 13:59 ` Hugues FRUCHET
2017-06-22 15:05 ` [PATCH v1 5/6] [media] ov9650: add multiple variant support Hugues Fruchet
2017-06-25 12:36 ` kbuild test robot [this message]
2017-06-22 15:05 ` [PATCH v1 6/6] [media] ov9650: add support of OV9655 variant Hugues Fruchet
2017-06-25 16:07 ` [PATCH] ov9650: fix semicolon.cocci warnings kbuild test robot
2017-06-25 16:07 ` [PATCH v1 6/6] [media] ov9650: add support of OV9655 variant kbuild test robot
2017-06-26 6:03 ` H. Nikolaus Schaller
2017-06-26 11:49 ` Hugues FRUCHET
2017-06-22 15:41 ` [PATCH v1 0/6] Add support of OV9655 camera H. Nikolaus Schaller
2017-06-23 10:25 ` H. Nikolaus Schaller
2017-06-25 9:18 ` omap3isp camera was " Pavel Machek
2017-06-26 6:05 ` H. Nikolaus Schaller
2017-06-26 8:39 ` Pavel Machek
2017-06-26 9:53 ` H. Nikolaus Schaller
2017-06-26 11:16 ` Pavel Machek
2017-06-27 5:49 ` H. Nikolaus Schaller
2017-06-26 13:19 ` Hugues FRUCHET
[not found] ` <E4E1E683-9CD0-4F23-AB03-080C52D0D73B@goldelico.com>
2017-06-27 7:57 ` Hugues FRUCHET
[not found] ` <95B10899-9966-4844-9667-D2434968A492@goldelico.com>
[not found] ` <85e62c47-e319-c801-376c-95f4d9cbf75a@st.com>
[not found] ` <E183E921-B8F4-4F8A-A302-58297A874990@goldelico.com>
[not found] ` <77bd3b8fe52643d68ecc821ec22bc0e6@SFHDAG5NODE1.st.com>
2017-07-01 21:00 ` H. Nikolaus Schaller
2017-07-03 8:16 ` Hugues FRUCHET
2017-07-03 9:14 ` H. Nikolaus Schaller
2017-07-03 12:03 ` Hugues FRUCHET
2017-07-03 12:23 ` H. Nikolaus Schaller
2017-07-05 14:02 ` H. Nikolaus Schaller
2017-07-08 20:55 ` Sakari Ailus
2017-06-26 6:02 ` H. Nikolaus Schaller
2017-06-26 10:05 ` Hugues FRUCHET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201706252047.pFxzMQ74%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=hns@goldelico.com \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).