* [PATCH] Modified imx7d-sdb.dts file so that VLDO4 provides 2.8V for MIPI CSI/DSI
@ 2017-06-28 17:45 mindentropy
2017-06-28 20:19 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: mindentropy @ 2017-06-28 17:45 UTC (permalink / raw)
To: festevam
Cc: mindentropy, Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring,
Mark Rutland, Russell King, linux-arm-kernel, devicetree,
linux-kernel
From: Gautam Bhat <mindentropy@gmail.com>
* According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
should be 2.8V but the voltage provided is a maximum of 3.3V and
minimum of 1.8V. Providing such a higher voltage might damage the
peripherals and violates the schematic settings.
Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
---
arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
index 5be01a1bf840..1da1f97ec342 100644
--- a/arch/arm/boot/dts/imx7d-sdb.dts
+++ b/arch/arm/boot/dts/imx7d-sdb.dts
@@ -262,8 +262,8 @@
};
vgen6_reg: vldo4 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
regulator-always-on;
};
};
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Modified imx7d-sdb.dts file so that VLDO4 provides 2.8V for MIPI CSI/DSI
2017-06-28 17:45 [PATCH] Modified imx7d-sdb.dts file so that VLDO4 provides 2.8V for MIPI CSI/DSI mindentropy
@ 2017-06-28 20:19 ` Fabio Estevam
2017-07-01 7:39 ` [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to " mindentropy
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2017-06-28 20:19 UTC (permalink / raw)
To: mindentropy
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring,
Mark Rutland, Russell King, linux-arm-kernel, devicetree,
linux-kernel
Hi Gautam,
On Wed, Jun 28, 2017 at 2:45 PM, mindentropy <mindentropy@gmail.com> wrote:
> From: Gautam Bhat <mindentropy@gmail.com>
>
> * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
> should be 2.8V but the voltage provided is a maximum of 3.3V and
> minimum of 1.8V. Providing such a higher voltage might damage the
> peripherals and violates the schematic settings.
>
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
Patch looks good, but the Subject could be improved to something like:
ARM: dts: imx7d-sdb: Set LDO4 to 2.8V
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI
2017-06-28 20:19 ` Fabio Estevam
@ 2017-07-01 7:39 ` mindentropy
2017-07-01 12:41 ` Fabio Estevam
2017-07-12 7:18 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: mindentropy @ 2017-07-01 7:39 UTC (permalink / raw)
To: festevam
Cc: Gautam Bhat, Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring,
Mark Rutland, Russell King,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
From: Gautam Bhat <mindentropy@gmail.com>
* According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
should be 2.8V but the voltage provided is a maximum of 3.3V and
minimum of 1.8V. Providing such a higher voltage might damage the
peripherals and violates the schematic settings.
Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
---
Changes in v2:
- Added subject line according to convention
arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
index 5be01a1bf840..1da1f97ec342 100644
--- a/arch/arm/boot/dts/imx7d-sdb.dts
+++ b/arch/arm/boot/dts/imx7d-sdb.dts
@@ -262,8 +262,8 @@
};
vgen6_reg: vldo4 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
regulator-always-on;
};
};
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI
2017-07-01 7:39 ` [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to " mindentropy
@ 2017-07-01 12:41 ` Fabio Estevam
2017-07-12 7:18 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-07-01 12:41 UTC (permalink / raw)
To: mindentropy
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring,
Mark Rutland, Russell King,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Sat, Jul 1, 2017 at 4:39 AM, mindentropy <mindentropy@gmail.com> wrote:
> From: Gautam Bhat <mindentropy@gmail.com>
>
> * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
> should be 2.8V but the voltage provided is a maximum of 3.3V and
> minimum of 1.8V. Providing such a higher voltage might damage the
> peripherals and violates the schematic settings.
>
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI
2017-07-01 7:39 ` [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to " mindentropy
2017-07-01 12:41 ` Fabio Estevam
@ 2017-07-12 7:18 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2017-07-12 7:18 UTC (permalink / raw)
To: mindentropy
Cc: festevam, Sascha Hauer, Fabio Estevam, Rob Herring, Mark Rutland,
Russell King,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Sat, Jul 01, 2017 at 01:09:11PM +0530, mindentropy wrote:
> From: Gautam Bhat <mindentropy@gmail.com>
>
> * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
> should be 2.8V but the voltage provided is a maximum of 3.3V and
> minimum of 1.8V. Providing such a higher voltage might damage the
> peripherals and violates the schematic settings.
For such single paragraph commit log, the bullet and indentation are not
really necessary. I edited it a bit and apply the patch. Thanks.
Shawn
>
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
> ---
> Changes in v2:
> - Added subject line according to convention
>
> arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index 5be01a1bf840..1da1f97ec342 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -262,8 +262,8 @@
> };
>
> vgen6_reg: vldo4 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <3300000>;
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> regulator-always-on;
> };
> };
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-12 7:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 17:45 [PATCH] Modified imx7d-sdb.dts file so that VLDO4 provides 2.8V for MIPI CSI/DSI mindentropy
2017-06-28 20:19 ` Fabio Estevam
2017-07-01 7:39 ` [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to " mindentropy
2017-07-01 12:41 ` Fabio Estevam
2017-07-12 7:18 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).