linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: ibm: ibmveth: constify dev_pm_ops structures.
@ 2017-06-29  5:44 Arvind Yadav
  2017-06-29 19:49 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-29  5:44 UTC (permalink / raw)
  To: benh, paulus, mpe, tlfalcon; +Cc: linuxppc-dev, netdev, linux-kernel

dev_pm_ops are not supposed to change at runtime. All functions
working with dev_pm_ops provided by <linux/device.h> work with const
dev_pm_ops. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  15426	   1256	      0	  16682	   412a	drivers/net/ethernet/ibm/ibmveth.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  15618	   1064	      0	  16682	   412a	drivers/net/ethernet/ibm/ibmveth.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/net/ethernet/ibm/ibmveth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 72ab7b6..02b26bf 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1843,7 +1843,7 @@ static int ibmveth_resume(struct device *dev)
 };
 MODULE_DEVICE_TABLE(vio, ibmveth_device_table);
 
-static struct dev_pm_ops ibmveth_pm_ops = {
+static const struct dev_pm_ops ibmveth_pm_ops = {
 	.resume = ibmveth_resume
 };
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: ibm: ibmveth: constify dev_pm_ops structures.
  2017-06-29  5:44 [PATCH] net: ibm: ibmveth: constify dev_pm_ops structures Arvind Yadav
@ 2017-06-29 19:49 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-29 19:49 UTC (permalink / raw)
  To: arvind.yadav.cs
  Cc: benh, paulus, mpe, tlfalcon, linuxppc-dev, netdev, linux-kernel

From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Thu, 29 Jun 2017 11:14:50 +0530

> dev_pm_ops are not supposed to change at runtime. All functions
> working with dev_pm_ops provided by <linux/device.h> work with const
> dev_pm_ops. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   15426	   1256	      0	  16682	   412a	drivers/net/ethernet/ibm/ibmveth.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   15618	   1064	      0	  16682	   412a	drivers/net/ethernet/ibm/ibmveth.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-29 19:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29  5:44 [PATCH] net: ibm: ibmveth: constify dev_pm_ops structures Arvind Yadav
2017-06-29 19:49 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).