From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Russell King <linux@armlinux.org.uk>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver
Date: Thu, 29 Jun 2017 20:00:55 +0200 [thread overview]
Message-ID: <20170629180055.ga6jgonch6dhowyi@pengutronix.de> (raw)
In-Reply-To: <21ca1ecb-39ac-5d43-71a2-d566974ab577@st.com>
Hello,
On Thu, Jun 29, 2017 at 02:40:44PM +0000, Pierre Yves MORDRET wrote:
> >> + /* Arbitration loss */
> >> + if (status & STM32F7_I2C_ISR_ARLO) {
> >> + dev_err(dev, "<%s>: Arbitration loss\n", __func__);
> >
> > Drop this. Arbitration loss is not an error and it shouldn't pollute the
> > kernel log.
> >
>
> I would like to keep it as indication though.
> Agree with dev_warn ?
No, dev_debug is ok.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2017-06-29 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 11:41 [PATCH v2 0/5] Add support for the STM32F7 I2C Pierre-Yves MORDRET
2017-06-20 11:41 ` [PATCH v2 1/5] dt-bindings: i2c-stm32: Document the STM32F7 I2C bindings Pierre-Yves MORDRET
2017-06-22 21:04 ` Rob Herring
2017-06-20 11:41 ` [PATCH v2 2/5] i2c: i2c-stm32f4: use generic definition of speed enum Pierre-Yves MORDRET
2017-06-20 11:41 ` [PATCH v2 3/5] i2c: i2c-stm32f7: add driver Pierre-Yves MORDRET
2017-06-27 20:51 ` Uwe Kleine-König
2017-06-29 14:40 ` Pierre Yves MORDRET
2017-06-29 18:00 ` Uwe Kleine-König [this message]
2017-06-20 11:41 ` [PATCH v2 4/5] ARM: dts: stm32: Add I2C1 support for STM32F746 SoC Pierre-Yves MORDRET
2017-06-20 11:41 ` [PATCH v2 5/5] ARM: dts: stm32: Add I2C1 support for STM32F746 eval board Pierre-Yves MORDRET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629180055.ga6jgonch6dhowyi@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).