* [PATCH] pinctrl: rza1: make structures rza1_gpiochip_template and rza1_pinmux_ops static
@ 2017-06-30 10:26 Colin King
2017-06-30 13:49 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-06-30 10:26 UTC (permalink / raw)
To: Linus Walleij, linux-gpio; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
structures rza1_gpiochip_template and rza1_pinmux_ops do not need to be
in global scope, so make them static.
Cleans up sparse warnings:
symbol 'rza1_gpiochip_template' was not declared. Should it be static?
symbol 'rza1_pinmux_ops' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pinctrl/pinctrl-rza1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
index 614a043f3038..29ddd624fb98 100644
--- a/drivers/pinctrl/pinctrl-rza1.c
+++ b/drivers/pinctrl/pinctrl-rza1.c
@@ -723,7 +723,7 @@ static void rza1_gpio_set(struct gpio_chip *chip, unsigned int gpio,
rza1_pin_set(port, gpio, value);
}
-struct gpio_chip rza1_gpiochip_template = {
+static struct gpio_chip rza1_gpiochip_template = {
.request = rza1_gpio_request,
.free = rza1_gpio_free,
.get_direction = rza1_gpio_get_direction,
@@ -1026,7 +1026,7 @@ static int rza1_set_mux(struct pinctrl_dev *pctldev, unsigned int selector,
return 0;
}
-struct pinmux_ops rza1_pinmux_ops = {
+static struct pinmux_ops rza1_pinmux_ops = {
.get_functions_count = pinmux_generic_get_function_count,
.get_function_name = pinmux_generic_get_function_name,
.get_function_groups = pinmux_generic_get_function_groups,
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: rza1: make structures rza1_gpiochip_template and rza1_pinmux_ops static
2017-06-30 10:26 [PATCH] pinctrl: rza1: make structures rza1_gpiochip_template and rza1_pinmux_ops static Colin King
@ 2017-06-30 13:49 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-06-30 13:49 UTC (permalink / raw)
To: Colin King; +Cc: linux-gpio, kernel-janitors, linux-kernel
On Fri, Jun 30, 2017 at 12:26 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> structures rza1_gpiochip_template and rza1_pinmux_ops do not need to be
> in global scope, so make them static.
>
> Cleans up sparse warnings:
> symbol 'rza1_gpiochip_template' was not declared. Should it be static?
> symbol 'rza1_pinmux_ops' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-30 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 10:26 [PATCH] pinctrl: rza1: make structures rza1_gpiochip_template and rza1_pinmux_ops static Colin King
2017-06-30 13:49 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).