linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence
@ 2017-07-02 14:40 Lynn Lei
  2017-07-03  6:20 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Lynn Lei @ 2017-07-02 14:40 UTC (permalink / raw)
  To: sudipm.mukherjee; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel

include PANEL_DISPLAY_CTRL_FPVDDEN control mask

Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
---
 drivers/staging/sm750fb/ddk750_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index 0f666dc2729a..c68367e6cdeb 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay)
 	u32 reg;
 	u32 opt[] = {
 		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
-		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
+		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,
 	};
 	u32 size, i;
 
-- 
2.13.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence
  2017-07-02 14:40 [PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence Lynn Lei
@ 2017-07-03  6:20 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-07-03  6:20 UTC (permalink / raw)
  To: Lynn Lei; +Cc: sudipm.mukherjee, devel, linux-fbdev, teddy.wang, linux-kernel

On Sun, Jul 02, 2017 at 10:40:33PM +0800, Lynn Lei wrote:
> include PANEL_DISPLAY_CTRL_FPVDDEN control mask


Does the subject match this?

> Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
> index 0f666dc2729a..c68367e6cdeb 100644
> --- a/drivers/staging/sm750fb/ddk750_display.c
> +++ b/drivers/staging/sm750fb/ddk750_display.c
> @@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay)
>  	u32 reg;
>  	u32 opt[] = {
>  		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
> -		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
> +		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,

Are you sure this is allowed?  Why is this patch correct?

And again, it doesn't match the subject line :(

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-03  6:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-02 14:40 [PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence Lynn Lei
2017-07-03  6:20 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).